Bug#227232: apache: Overwrites own modules.conf on upgrade
On Tue, 20 Jan 2004, Jeroen van Wolffelaar wrote:
> > > I'm now going to clean up the mess and restore config from backup, and I
> > > will check out the postinst afterwards, if I find more problems, or a
> > > patch for this, I will add to this report and/or open another one.
> >
> > No need to. I know where the problem is (unfortunatly).
>
> Ok, that's half of the reason I didn't yet do so (other reason: RL)
>
> I noticed the problem, IMHO is in the cp -f modules.conf
> modules.conf.old without any checking wether old exists, so only keeping
> one backup (and on postinst rerun original modules.conf is lost).
Yes i have this in mind as well. I am evaluating the possibility to
perform a full backup of the configs each time since now we have the tool
to do so.
> > > Above this, why modules-config? You cannot add comments next to the
> > > loadmodule line like this?!
> >
> > sorry but i don't understand what you mean.
>
> Without modules-config, you can maintain a configuration fragment with
> the LoadModule lines, and have comments above them, as a kind of
> reminder for yourself: what is it, what's it relevance to my own system,
> and why did I disable/enable this module.
>
> With modules-config, that is AFAICS impossible.
that's correct because it is generated automatically. Maintaing comments
inside isn't impossible just a lot more work for modules-config. I
consider this as a wishlist but i will see if i can find the time to fix
it after this bug that is more important.
> Okay, I agree & understand here :), thanks for the explaination.
>
> So I understand you will in the future mimic apache2's way of handling
> apache-modules? I believe that would greatly improve Debian's
> consistency.
Yes that's correct. As you might have noticed we already started
introducing conf.d as a testbed and several packages are using it. Next
steps will be to introduce the modules structure.
> ... indeed, I don't blame anyone, my goal is to provide an as useful as
> possible bugreport to assist apache-maintainers fixing it in order to
> prevent this bug slip into sarge :)
>
> Sorry if I was unclear about this, and thanks for all the good work.
Thanks to you!
Fabio
--
Our mission: make IPv6 the default IP protocol
"We are on a mission from God" - Elwood Blues
http://www.itojun.org/paper/itojun-nanog-200210-ipv6isp/mgp00004.html
Reply to: