[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: apacheconfig patch review requested

On Tue, Jan 15, 2002 at 05:27:44PM +0000, Matthew Wilcox wrote:
> Hi.  Anyone know perl?  :-)
> Bug #12094 (apache's oldest still-open bug!), #59998, #105820 and now
> #129372 would seem to all be fixable by the patch attached to #105820.
> Thanks to Steve Stock for supplying the patch.  Since I don't grok perl,
> I'd just like someone to review it and see if it looks reasonable.
> If it is, I'll incorporate it in apache 1.3.22-6.

Well, the two BUG comments upset me a bit.  The latter at least is a
problem.  It should be possible to solve both fairly easily - the
former with a hash table (preferably hashing on inode/dev rather than
filename) and the latter by prepending /etc/apache to relative paths. 
I'm fairly certain Apache does nothing more complicated than that.

Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Reply to: