[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] make pam use correct lastlog time value on X86-64

Am Sonntag, 14. März 2004 21:24 schrieb Sam Hartman:
> Hi.  It seems you are needlessly adding conditionals.  ANy reason the
> AMD64 case wouldn't just work on all platforms?  IF so, I'll just
> apply the AMD64 part of the conditional everywhere.
> --Sam

I also do not like too many conditionals, but I also do not like the whole 
issue where we have similar variables, but with different data size, which 
requires unproductive back and forth copying. Although I do not see how the 
patch (or should I say workaround) could create a problem for all the other 
architectures, my hope is that at some point in time, the necessity for the 
workaround goes away, and if it is placed between conditionals, (I hope) it 
is then easier to be identified and to be removed :-)

Hans-Frieder Vogt                 e-mail: hfvogt@arcor.de

Reply to: