[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Updated installation images for Debian Ports 2019-11-22

On Sat, Nov 30, 2019 at 05:51:45PM +0100, John Paul Adrian Glaubitz wrote:
> > On Nov 30, 2019, at 4:54 PM, Skye <skye@20maguire.com> wrote:
> > 
> > Bob, that is excellent information.   Thank you for sharing!
> I suggest turning this into a patch. Fixing guile-2.0 and guile-2.2 on alpha is dearly needed, so patches are really welcome.
> Adrian

I definitely appreciate that fixing the guile-2.0 and guile-2.2 builds on
alpha is a priority, and if there was anything useful I could contribute
beyond demonstrating it can be done, I'd be happy to provide patches.

The problem *I* ran into was entirely due to how s-l-o-w my system is.
Since the issue is associated with exactly *one* of the guile-2.2 tests
(for the "guild" compiler), I'm reluctant to have a "hack" workaround
become part of the test suite source, especially since the problem will
never be seen on one of the "buildd" hosts.  I didn't see the problem
with the exact same test on the "guile-2.0" build because 2.0 runs more
efficiently on older, slower systems.

If you feel otherwise as far as wanting a patch, the simple diff is
appended below.  Nothing magical about the "sleep" values I picked.  The
first one is to allow enough time for the "guild" compiler to actually
begin doing something, and *may* be too long to wait for a machine that
can actually get out of its own way :-(.  The second sleep value can be
anything less than the 100 seconds allowed by the test script for the
compile to complete, but needs to be long enough to allow the "guild"
compiler to receive and process the sent SIGINT.

All that being said, I'd *definitely* think twice about blindly changing
the sleep values.  Again, you'll never see this issue on the "buildd"
systems.  If I were the package maintainer, I'd reject this patch :-).

(file is in "guile-2.2-2.2.6+1/test-suite/standalone" after extracting
the source package)

--- test-guild-compile.orig	2019-11-30 17:56:39.276270948 -0600
+++ test-guild-compile	2019-11-30 17:57:18.874959718 -0600
@@ -23,10 +23,10 @@
 # Send SIGINT.
-sleep 2 && kill -INT "$pid"
+sleep 5 && kill -INT "$pid"
 # Wait for 'guild compile' to terminate.
-sleep 2
+sleep 15
 # Check whether there are any leftovers.
 for file in "$target"*

Reply to: