Re: reiser4 kernel patch....
Not certain if it's an on on-disk structure - it is used all over,
but the comments in it would suggest that it is in-memory only
(especially since it contains at least one pointer, which would
make little sense in an on disk struct).
Even in that case, the purpose of the cassert() in the coords_equal()
function is to track changes to the structure and probably shouldn't
be "disabled" simply for the purpose of making it compile.
...tom
On Thu, 2004-09-09 at 19:29, Tyson Whitehead wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> > Just checked - the Andrew Morton -mm4 patch has the offending cassert
> > ifdef'd out.
> >
> > This is why the reiser4 stuff compiles on 64bit platforms in that patch.
>
> Hummm, I wonder if that structure gets written out to disk?
>
> If so, I'm thinking the the mm4 solution, ifdefing it out, may result in
> Reiser4 filesystems created on 64bit platforms not being compatible with
> those on 32bit...
>
> Yur __attribute__((packed)) would be the correct solution in this case.
>
> - -T
>
> - --
> Tyson Whitehead (-twhitehe@uwo.ca -- WSC-)
> Computer Engineer Dept. of Applied Mathematics,
> Graduate Student- Applied Mathematics University of Western Ontario,
> GnuPG Key ID# 0x8A2AB5D8 London, Ontario, Canada
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.2.4 (GNU/Linux)
>
> iD8DBQFBQOdbRXbLmIoqtdgRAgCPAKC5GjdWfcNoPW1zsHGLopTU6wLfWACffovX
> z9OjsyQuocK50UrdHpPRs+k=
> =Px93
> -----END PGP SIGNATURE-----
>
Reply to: