[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug in kernel 2.4.3?



Craig Small <csmall@eye-net.com.au> wrote:

> I tried compiling the 2.4.3 kernel with the tlb and numa-2 patches.
> But there is definitely something wrong with
> include/linux/kernel.h, it has:

> #define PADDING 22 + sizeof(short) - 3 * sizeof(long) - sizeof(int)
>        char _f[PADDING];               /* Padding: libc5 uses this.. */

> 22 + 2 - (3 * 8 ) - 4 = 22 + 2 - 24 - 4 = -4

> I'm going to try to remove the padding and see if that works, it may
> be ok due to the comment. (I hope so anyway).

Removing it should be fine.  Either that or apply this patch.
-- 
Debian GNU/Linux 2.2 is out! ( http://www.debian.org/ )
Email:  Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
diff -u -r1.5 kernel.h
--- include/linux/kernel.h	2001/02/11 20:41:04	1.5
+++ include/linux/kernel.h	2001/04/13 09:10:52
@@ -127,9 +127,9 @@
 	unsigned long totalhigh;	/* Total high memory size */
 	unsigned long freehigh;		/* Available high memory size */
 	unsigned int mem_unit;		/* Memory unit size in bytes */
-#define PADDING 22 + sizeof(short) - 3 * sizeof(long) - sizeof(int)
-	char _f[PADDING];		/* Padding: libc5 uses this.. */
-#undef PADDING
+#define P 22 + sizeof(short) - 3 * sizeof(long) - sizeof(int)
+	char _f[P > 0 ? P : 0];		/* Padding: libc5 uses this.. */
+#undef P
 };
 
 #endif



Reply to: