Bug#1121159: librocm-smi-dev should depend on libdrm-dev

[Gennaro Oliva <oliva@debian.org>]

Package: librocm-smi-dev
Version: 6.4.1-1
Severity: important
X-Debbugs-Cc: oliva@debian.org
 
Dear Maintainer,

while building software that uses ROCm SMI (e.g. Slurm), I noticed that the
package librocm-smi-dev installs the header /usr/include/rocm_smi/kfd_ioctl.h
that unconditionally include libdrm/drm.h, but the package does not Depend or
on libdrm-dev.

This issue affects packages building against ROCm SMI (e.g. Slurm), making
configure tests fail with:

error: unable to locate librocm_smi64.so and/or rocm_smi.h

Please consider adding the appropriate Depends/Build-Depends. I am attaching a
patch that adds libdrm-dev to librocm-smi-dev to fix the missing header
dependency.

Thanks for your work.

-- System Information:
Debian Release: 12.12
  APT prefers oldstable-updates
  APT policy: (500, 'oldstable-updates'), (500, 'oldstable-security'), (500, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-40-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages librocm-smi-dev depends on:
pn  librocm-smi64-1  <none>

librocm-smi-dev recommends no packages.

librocm-smi-dev suggests no packages.

-- 
Gennaro Oliva

diff --git a/debian/control b/debian/control
index 904acd0..39e560b 100644
--- a/debian/control
+++ b/debian/control
@@ -40,6 +40,7 @@ Package: librocm-smi-dev
 Architecture: linux-any
 Section: libdevel
 Depends: ${misc:Depends},
+         libdrm-dev,
          librocm-smi64-1 (= ${binary:Version})
 Recommends: liboam-dev (= ${binary:Version})
 Description: ROCm System Management Interface (ROCm SMI) library headers