[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1118618: Updating rocr-runtime libraries to 6.4 causes llama.cpp/ggml to fail



Thank you for the report.

I was testing with packages built against newer versions of the HIP Runtime, so I didn't catch this regression. I'd only tested the basics with rocminfo, which worked fine for this case because it doesn't use the broken function.

The problem seems to be that upstream changed the ABI of hsa_agent_iterate_isas by changing the types for the callback function:

Old Callback Data Definition:

    std::pair<hsa_isa_t, bool> comparison_data

New Callback Data Definition:

    struct callBackData {
        std::pair<hsa_isa_t, bool> comparison_data;
        const unsigned int codeGenericV;
    };

Sincerely,
Cory Bloor


Reply to: