[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1116585: marked as done (amd_hip_bf16.h: bf16 functions need to be static)

Your message dated Sat, 04 Oct 2025 08:54:22 +0000
with message-id <E1v4y22-006LYq-1u@fasolo.debian.org>
and subject line Bug#1116585: fixed in rocm-hipamd 5.7.1-7
has caused the Debian Bug report #1116585,
regarding amd_hip_bf16.h: bf16 functions need to be static
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1116585: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1116585
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: libamdhip64-dev
Version: 5.7.1-6
Severity: important
Tags: patch

Dear Maintainer,

Newer versions of ggml fail to build from source with HIP <= 6.0, with
linking failures such as the following:

> /usr/bin/ld: CMakeFiles/ggml-hip.dir/__/ggml-cuda/add-id.cu.o: in function `__float2bfloat16(float)':
> /usr/include/hip/amd_detail/amd_hip_bf16.h:143: multiple definition of `__float2bfloat16(float)'; CMakeFiles/ggml-hip.dir/__/ggml-cuda/acc.cu.o:/usr/include/hip/amd_detail/amd_hip_bf16.h:143: first defined here
> /usr/bin/ld: CMakeFiles/ggml-hip.dir/__/ggml-cuda/add-id.cu.o: in function `__bfloat162float(__hip_bfloat16)':
> /usr/include/hip/amd_detail/amd_hip_bf16.h:125: multiple definition of `__bfloat1622float2(__hip_bfloat162)'; CMakeFiles/ggml-hip.dir/__/ggml-cuda/acc.cu.o:/usr/include/hip/amd_detail/amd_hip_bf16.h:125: first defined here
> ...

According to upstream the upstream fix introduced in a later version
[1], this is because the functions in the bf16 header need to static.

Marking as important as it blocks the update of another package.

The fix seems simple enough, I will submit a PR.

> diff --git a/hipamd/include/hip/amd_detail/amd_hip_bf16.h b/hipamd/include/hip/amd_detail/amd_hip_bf16.h
> index 50b8a18..4e4a96e 100644
> --- a/hipamd/include/hip/amd_detail/amd_hip_bf16.h
> +++ b/hipamd/include/hip/amd_detail/amd_hip_bf16.h
> @@ -91,10 +91,10 @@
>  #include "math_fwd.h"              // ocml device functions
>  
>  #if defined(__HIPCC_RTC__)
> -#define __HOST_DEVICE__ __device__
> +#define __HOST_DEVICE__ __device__ static
>  #else
>  #include <climits>
> -#define __HOST_DEVICE__ __host__ __device__
> +#define __HOST_DEVICE__ __host__ __device__ static inline
>  #endif
>  
>  // Since we are using unsigned short to represent data in bfloat16, it can be of different sizes on

Best,
Christian

[1]: https://github.com/ROCm/clr/commit/77c581a3ebd47b5e2908973b70adea66891159ee

--- End Message ---
--- Begin Message --- 
Source: rocm-hipamd
Source-Version: 5.7.1-7
Done: Cordell Bloor <cgmb@slerp.xyz>

We believe that the bug you reported is fixed in the latest version of
rocm-hipamd, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1116585@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Cordell Bloor <cgmb@slerp.xyz> (supplier of updated rocm-hipamd package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 04 Oct 2025 02:33:54 -0600
Source: rocm-hipamd
Architecture: source
Version: 5.7.1-7
Distribution: unstable
Urgency: medium
Maintainer: Debian ROCm Team <debian-ai@lists.debian.org>
Changed-By: Cordell Bloor <cgmb@slerp.xyz>
Closes: 1107681 1116585
Changes:
 rocm-hipamd (5.7.1-7) unstable; urgency=medium
 .
   * Add d/p/0041-inline-bf16-functions.patch to mark functions defined
     in amd_hip_bf16.h as inline. This change prevents multiple
     definition errors during linking for programs that include
     <hip/hip_bf16.h> in more than one translation unit (Closes: #1116585)
   * Fix hipcc manpage title (Closes: #1107681)
   * Fix spelling error in roc-obj-ls manpage
Checksums-Sha1:
 55e4fffab14ef86cbedb9c452ab1debb62b78ac7 3529 rocm-hipamd_5.7.1-7.dsc
 287930d6fd3f2fba2b86789fe2001674683b0b3a 30304 rocm-hipamd_5.7.1-7.debian.tar.xz
 817524da873daffd894aa175721481174a9dbb20 9712 rocm-hipamd_5.7.1-7_source.buildinfo
Checksums-Sha256:
 9a57209ab1b34230448e8d4c2f04b5c311d2ae4f187282b3b7a22740d52dbd49 3529 rocm-hipamd_5.7.1-7.dsc
 8d308f0aff7daa28584b2e593a88d712af7d7393af04a64fcd4fb77885dbbbee 30304 rocm-hipamd_5.7.1-7.debian.tar.xz
 e4c7639f4e7c7508ca4c4df7404433eb18f456d8bd52f3f0c6461a3fc9d137d1 9712 rocm-hipamd_5.7.1-7_source.buildinfo
Files:
 feb0244fdd89125e97c65652390d47de 3529 devel optional rocm-hipamd_5.7.1-7.dsc
 75738a4e37ac36618cc431b00bafabff 30304 devel optional rocm-hipamd_5.7.1-7.debian.tar.xz
 d84755f3eec46088a5982e33e2b958fc 9712 devel optional rocm-hipamd_5.7.1-7_source.buildinfo

-----BEGIN PGP SIGNATURE-----

wsG7BAEBCgBvBYJo4NyYCRD5747gwCFjD0cUAAAAAAAeACBzYWx0QG5vdGF0aW9u
cy5zZXF1b2lhLXBncC5vcmfWmqBMZAclqbGcPPfDLkHl10ao7QZyr9a7sAMLhJOM
iBYhBAzgb+OSqkj40i5EcfnvjuDAIWMPAAAo/RAAy2wN+NklgtSqV6tuD968SUd7
EKCui3OYLqzEe6XtNI8dtOeiHFAf8AnIBvNyhPMW2+hQA8k32GXjHylLdo34JOit
1gUC/CiIixZmpDDGJmuYmVAiYZaF1U1mVr7ZuL1ivAbgsjzKAuL41L1pNU36InFj
DmfEysasnTjYtMRLaVpewPGTmT5O/k4oIfAEiGRIW5OPL0wemdKOoCzEP6rwf/1w
hHP0CfigKh0wiJJCLMuXzICQlAPFehVBXyJAQ8clQTDgS9bgMAueuxBmENnQpPq4
YrHttkiPHlYCjXjwxkKMe3vwAJanTpFg7Wz+l8cweIJn4RsmQKwTzk+PMcZtXOC8
Zd6n90JKaNuNYj3wtYGDUZLOnDeZgavLEtsGhFEcrz+TUTOeRW/4IKFQDtvi+jOE
B5P/wxBil1jpIQRosiGrv652qR/kAR2X4Qr8ti8oVBCFVMWi179d5+Ao3XUOIVXV
639emGuM0eawBEHmkRP3lifqQGs3y7c74U7w9eCL+s7BbInrvzM9UrR97YGGN+yq
OA7BkmBnMUhAbKNFwtKuZGnPwrbT6z3MULhiSmZ0zPrRo5zDBDqiPjDlhRk0jFLC
sGx0FQ697ZMdZP6qMHTB11EXCG3CIeOHgRlvCEpcIkOYGDCWPjQHbKbESaNCYmLr
0vOl84g2qukVlTP9w+4=
=qQNJ
-----END PGP SIGNATURE-----

Attachment: pgpZuyZy6Dj0a.pgp
Description: PGP signature


--- End Message ---
Reply to: