[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1114772: marked as done (rocm-docs-core: please make the build reproducible)

Your message dated Wed, 10 Sep 2025 10:05:18 +0000
with message-id <E1uwHhW-005hgy-1y@fasolo.debian.org>
and subject line Bug#1114772: fixed in rocm-docs-core 1.23.0-5
has caused the Debian Bug report #1114772,
regarding rocm-docs-core: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1114772: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1114772
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: rocm-docs-core
Version: 1.23.0-3
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timezone
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
rocm-docs-core could not be built reproducibly.

This is because the documentation includes timestamps that vary on the
current build timezone. (The absolute timestamps are calculated from
the modification time of the file.)

Patch attached that prints these as UTC by changing a fromtimestamp to
a utcfromtimestamp.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

--- a/debian/patches/0007-Reproducible-build.patch	1969-12-31 16:00:00.000000000 -0800
--- b/debian/patches/0007-Reproducible-build.patch	2025-09-09 11:00:49.134077523 -0700
@@ -0,0 +1,25 @@
+Description: Make the build reproducible
+Author: Chris Lamb <lamby@debian.org>
+Last-Update: 2025-09-09
+
+--- rocm-docs-core-1.23.0.orig/src/rocm_docs/article_info.py
++++ rocm-docs-core-1.23.0/src/rocm_docs/article_info.py
+@@ -158,7 +158,7 @@ def _set_all_article_info(
+ 
+         if "ROCM_DOCS_NO_GIT" in os.environ:
+             logger.debug("Disabling GIT query for date, use timestamp : %s", Path(app.srcdir, page_rel))
+-            date_info = datetime.datetime.fromtimestamp(os.path.getmtime(Path(app.srcdir, page_rel))).strftime("%Y-%m-%d")
++            date_info = datetime.datetime.utcfromtimestamp(os.path.getmtime(Path(app.srcdir, page_rel))).strftime("%Y-%m-%d")
+         else:
+             date_info = _get_time_last_modified(repo, Path(app.srcdir, page_rel))
+ 
+--- rocm-docs-core-1.23.0.orig/docs/conf.py
++++ rocm-docs-core-1.23.0/docs/conf.py
+@@ -35,6 +35,7 @@ article_pages = [
+     },
+     {
+         "file": "developer_guide/commitizen",
++        "date": "",
+     },
+ ]
+ 
--- a/debian/patches/series	2025-09-09 10:47:27.910466834 -0700
--- b/debian/patches/series	2025-09-09 10:56:51.150456499 -0700
@@ -2,3 +2,4 @@
 0003-Don-t-fail-if-not-in-git-repo.patch
 0006-Fix-linking-toc.patch
 0004-Merge-Get-data-from-env-and-Add-option-to-skip-theme.patch
+0007-Reproducible-build.patch

--- End Message ---
--- Begin Message --- 
Source: rocm-docs-core
Source-Version: 1.23.0-5
Done: Christian Bayle <bayle@debian.org>

We believe that the bug you reported is fixed in the latest version of
rocm-docs-core, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1114772@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Bayle <bayle@debian.org> (supplier of updated rocm-docs-core package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 10 Sep 2025 11:24:49 +0200
Source: rocm-docs-core
Architecture: source
Version: 1.23.0-5
Distribution: unstable
Urgency: medium
Maintainer: Debian ROCm Team <debian-ai@lists.debian.org>
Changed-By: Christian Bayle <bayle@debian.org>
Closes: 1114772
Changes:
 rocm-docs-core (1.23.0-5) unstable; urgency=medium
 .
   * Use UTC timestamp (Closes: #1114772)
Checksums-Sha1:
 580a3613f19b9ab80d0ba392a43407240f3edd7e 2564 rocm-docs-core_1.23.0-5.dsc
 61a0bb8ef8b3644a6b732dc834be03d71e3cdf08 16080 rocm-docs-core_1.23.0-5.debian.tar.xz
 c99f04f646a42ba95edebebc3c8b69be91e86353 15852 rocm-docs-core_1.23.0-5_amd64.buildinfo
Checksums-Sha256:
 7326dc34466f8537150c87987f7aa049978274882c75e6a87566e5d639890568 2564 rocm-docs-core_1.23.0-5.dsc
 4eec13f997a114b4bc11e56a4282c107ef42d1923696e9c1ee4614d3abd7214b 16080 rocm-docs-core_1.23.0-5.debian.tar.xz
 ffde7ca4803b7071b56f8d78fa054c104597aa61e81ffff9b92e4e00c7d738c2 15852 rocm-docs-core_1.23.0-5_amd64.buildinfo
Files:
 20dd2c902fd11526bc638c0aa69d3871 2564 python optional rocm-docs-core_1.23.0-5.dsc
 a2af51f020aa2c631dd20e3d12015db5 16080 python optional rocm-docs-core_1.23.0-5.debian.tar.xz
 5acfd5c4e657730b9da4a239e01b4aef 15852 python optional rocm-docs-core_1.23.0-5_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEl9DisSUYWvfJX+x3a5gt67/pHCkFAmjBSDEACgkQa5gt67/p
HCnA5BAAi9gEzryJKRByMCaU44pHbxwM9wSGJZVGx+P/ZWdFhOg914AY6swxXOMI
ZeJbeYpHA1MtYnCNBCfrTI7Qdb1s/YAR0TppuSqw3VMZfkS1wmOEPImEJcpK2WNo
zYlfooaegx+5nxPDJJcO8phKRyRQkI3h1H9fOBc7oaHebBWmJDaBC21g9VW2gzW4
VT8URDiYFUlpxfcq2onPpDfqSXpT5OgKtyskOwWKzhe3flM9mNM+t57doAfVV9CD
h5pl4vVikDLuPZUZ1daFlKGjd8H+szjgMSbQGOY1QazVf1Ep+ndlJ3+GMq0L/gz9
6EAWe4FKCe890EmUGPAbUvljyVjM7t72JCSxKck3z+41rFWv3snfK3zu+8vwF4Iz
gK6Wl2b5ZWiwRSSfu/ryXl9GHmTxUyNvb09zK8DtRR3yRKZGHozLZ/4sfnHNbo5h
h97W2w8LctCW6rlyFBjKzlH+2DJ0UxxogPCQ4wvB6KICDymu0AxmCpuf4xu0jT4W
zDh3lwFKtdMX9wKvXdxZYS875M04E2dWLQa0ongK/FX+cr49gWyPEyc8H6EjYPgp
Vi5pjN4aa1postUsTl0pbQOyv7e2XlsQRjUYymU/6qkkX6qHqq9xWDkyNBBhhdj8
2avVpEHGRH1SENG+3dCQ5ZTRweYYEwHwnH5fHwbCQX0r2b5vrys=
=jDwX
-----END PGP SIGNATURE-----

Attachment: pgp0lUbTvV98A.pgp
Description: PGP signature


--- End Message ---
Reply to: