[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: rocm-all renaming



Hello,

Le 03/09/2025 à 06:16, Cordell Bloor a écrit :
On 2025-09-02 16:01, Christian BAYLE wrote:
I intent to package ROCm from
https://github.com/ROCm/ROCm
so retitled RFP to ITP - https://bugs.debian.org/1113780

It is mostly used to generate
https://rocmdocs.amd.com/ using Sphinx and rocm-docs-core

I think I'll provide an offine generated version
and probably a way to regenerate online

It's mostly done, but it requires two more sphinx
extensions, i'll upload too :
(ITP - #1113792) https://bugs.debian.org/1113792 sphinxcontrib-runcmd
(ITP - #1113780) https://bugs.debian.org/1113780 sphinxcontrib.datatemplates

Thank you very much for your efforts on this. I gave up on rocm-doc when I ran into the missing sphinxcontrib.datatemplates dependency.


I thought it might also make sense to provide the rocm-dev and rocm- tests packages from src:rocm, although there's no technical reason why that would need to be the case. It just seemed to make sense from an organizational standpoint as src:rocm is a superproject of all other ROCm projects.

I think it makes sense to use src:rocm to handle metapackages
maybe also something like rocm-lib and rocm-sys based on the coming code reorg where we can get the list with:

curl -s "https://api.github.com/repos/ROCm/rocm-systems/contents/projects?ref=develop"; | jq -r '.[] | select(.type == "dir") | .name'

curl -s "https://api.github.com/repos/ROCm/rocm-libraries/contents/projects?ref=develop"; | jq -r '.[] | select(.type == "dir") | .name'

or from
https://github.com/ROCm/rocm-docs-core/blob/develop/src/rocm_docs/data/projects.yaml

To build the doc offline, I use hardcoded values in rocm-docs-core/debian/rules

# https://raw.githubusercontent.com/ROCm/rocm-docs-core/data/latest_version.txt
latest_version="6.4.1"
# https://raw.githubusercontent.com/ROCm/rocm-docs-core/data/release_candidate.txt
release_candidate="6.4.2"
# https://raw.githubusercontent.com/ROCm/rocm-docs-core/data/google_site_verification.txt
google_site_verification = "vo35SZt_GASsTHAEmdww7AYKPCvZyzLvOXBl8guBME4"

ROCm is also extracting informations from git, when building docs
which requires some patch.

there is also
version = "6.4.3"
release = "6.4.3"
available in
https://github.com/ROCm/ROCm/blob/develop/docs/conf.py

I think these versions should be available in some static place
probably in rocm or rocm-docs-core package

rocm-docs-core data branch seems to be the official place
Any suggestion ?

I'm currently trying to write a dh-make-rocm helper to automate the source package initial version as much as possible from github rocm repositories
I think I'll propose that to integrate in the pkg-rocm-tools

I was also almost ready to upload src:rocm myself and I had just been debating if it made any sense to do so despite the binary packages I'd defined not actually using any of the upstream sources. If you have the rocm-doc build working, then that makes my concern moot.

If you think it makes sense for src:rocm to provide rocm-dev and rocm- tests in addition to rocm-doc, then perhaps we can merge your version of the package and my version of the package [1]. Alternatively, I could move rocm-dev and rocm-tests into their own source package and come up with some other name for it.


I think, I'll merge your work, and add you in uploaders ;-)

Regards

Christian


Reply to: