[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: rocm-llvm_6.1.2+dfsg-1~exp2_source.changes ACCEPTED into experimental



Hi Christian and Xuanteng,

On 2025-06-30 13:19, Debian FTP Masters wrote:
   [ Cordell Bloor ]
   * d/control: remove stray comma in maintainer field to fix
     the package information listed on tracker.debian.org.
   * d/control: add perl to hipcc dependencies
   * d/control: add libamdhip64-dev to hipcc recommended packages

I changed hipcc to recommend libamdhip64-dev. It's an improvement, but still not ideal. The hipcc package should depend on libamdhip64-dev because you cannot even compile even an empty file as a HIP source without libamdhip64-dev installed. Even if you do not include any HIP headers, the clang++ compiler will look for the HIP runtime and will exit with an error like this one if it cannot be found:

clang-17: error: cannot find HIP runtime; provide its path via '--rocm-path', or pass '-nogpuinc' to build without HIP runtime

There are a few other things you can do with the hipcc package, but it seems questionable that you cannot compile HIP programs with the HIP compiler unless you've installed its recommended packages.

This problem is ultimately the result of the move of hipcc from src:rocm-hipamd to src:rocm-llvm. The src:rocm-hipamd package Build-Depends on hipcc, so if we were to make libamdhip64-dev a dependency of hipcc, we'd have a circular dependency that could become a pain to bootstrap.

I suspect that src:rocm-hipamd doesn't _really_ require hipcc itself, but perhaps it needs some other parts of the hipcc package? We should investigate what src:rocm-hipamd really needs from the hipcc package and, if necessary, consider splitting hipcc into two smaller packages to break the circle.

As a hypothetical example, if src:rocm-hipamd only really needs hipconfig, then perhaps we can move hipconfig out of the hipcc binary package and into its own binary package that hipcc can depend on. Then hipcc can depend on libamdhip64-dev without introducing a cycle, as src:rocm-hipamd would merely Build-Depend on hipconfig.

Sincerely,
Cory Bloor


Reply to: