[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Finishing the ROCm 6 update



Hi Christian,

On 30/06/2025 08:22, Christian Kastner wrote:
Hi Christian,

Now I saw that you worked on rocblas (in the main repo), so I started to
look for clues, and found that you had worked on these in personal repos.

I hope I didn't duplicate too much work on rocsparse/hipsparse, and I'm
sorry that I didn't merge the work that you had already done.

not a problem, was also some kind of exercise for me with gbp rebase, as i'm far from understanding how all this works.

- src:rocblas (librocblas4)
- src:hipblas (libhipblas1)
Quite a bit depends on rocblas so perhaps the changes that you did for
6.1 should be merged into master? I think we need to get at least the
SOVER bump out of the way, fast.


not sure, feel free to reuse or throw away, I did my best, but my understanding is sometime very partial about what to do during some merge.
On my end, the updates of rocsparse, hipsparse, rocfft and hipfft
yesterday consisted of
   - an uneventful 30min-work part (updating the package following the
     steps done for rocrand, hiprand, rocprim)
   - a few hours working around bugs, and updating patches.

I'm sure this would have been far less if we had tracked releases more
closely, due to smaller deltas. We should keep that in mind for future
releases.

By the way, rocm-docs-core worked really straightforward. All docs need
two patches, but they are straightforward and can be copy-pasted.



I hardcoded some version in the debian/rules, that probably should be replaced with the reference from AMD code or placed in a config file
to be reused in all package
In TheRock there is a version.json, but I didn't find where latest_version.txt and release_candidate.txt comes from ...

===========================================
url=https://github.com/ROCm/rocm-docs-core
# When you set branch=latest you SHOULD get latest_version value in the header
# With branch=experimental you SHOULD get no version displayed
# See ./src/rocm_docs/rocm_docs_theme/flavors/rocm/header.jinja
#branch=experimental
branch=latest

# https://raw.githubusercontent.com/ROCm/rocm-docs-core/data/latest_version.txt
latest_version="6.4.1"
# https://raw.githubusercontent.com/ROCm/rocm-docs-core/data/release_candidate.txt
release_candidate="6.4.2"
# https://raw.githubusercontent.com/ROCm/rocm-docs-core/data/google_site_verification.txt
google_site_verification = "vo35SZt_GASsTHAEmdww7AYKPCvZyzLvOXBl8guBME4"
===========================================

Nevertheless this is not displayed, don't know why yet ...

I'm open to some suggestion about package i could help for, or missing python deps ;-)

Regards

Christian B.


Reply to: