[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1098945: marked as done (pkg-rocm-tools: please make the build reproducible)

Your message dated Fri, 14 Mar 2025 23:45:54 +0100
with message-id <7fc81603-fb01-41fd-8f87-12056cb498f7@debian.org>
and subject line Re: Bug#1098945: pkg-rocm-tools: please make the build reproducible
has caused the Debian Bug report #1098945,
regarding pkg-rocm-tools: please make the build reproducible
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1098945: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1098945
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: pkg-rocm-tools
Version: 0.8.1
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Hi,

Whilst working on the Reproducible Builds effort [0], we noticed that
pkg-rocm-tools could not be built reproducibly.

This is because the generated manual page contains values based on the
number of CPUs and amount of RAM on the system:

│ │ │ ├── ./usr/share/man/man1/rocm-qemu-run.1.gz
│ │ │ │ │  .TP
│ │ │ │ │  \fB\-m\fR MEM
│ │ │ │ │ -Guest RAM (default: 60301)
│ │ │ │ │ +Guest RAM (default: 60312)
│ │ │ │ │  .HP

Patch attached that changes the output to deterministic text values —
they remain dynamic defaults, however.

 [0] https://reproducible-builds.org/


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-


--- a/bin/rocm-qemu-run	2025-02-26 10:08:00.193109446 +0000
--- b/bin/rocm-qemu-run	2025-02-26 10:10:06.584543536 +0000
@@ -47,10 +47,10 @@
 
 	Options:
 	  -h         Show this help
-	  -c CPUS    Number of guest CPUs (default: $Ncores)
+	  -c CPUS    Number of guest CPUs (default: 75% of CPU cores)
 	  -d DIR     Mount host dir DIR as /shared in the guest
 	  -g GPU     PCI slot ID of GPU to pass through (eg: 09:00.0)
-	  -m MEM     Guest RAM (default: $Nmem)
+	  -m MEM     Guest RAM (default: 75% of memory)
 	  -p SSHPORT Forward host port PORT to guest port 22
 	  -s         Boot the VM in snapshot mode (changes are discarded)

--- End Message ---
--- Begin Message --- 
Version: 0.8.2

Thank you for the patch, it was included in the most recent upload but I
had a typo in the closing bug number.

Best,
Christian

On 2025-02-26 11:13, Chris Lamb wrote:
> Source: pkg-rocm-tools
> Version: 0.8.1
> Severity: wishlist
> Tags: patch
> User: reproducible-builds@lists.alioth.debian.org
> Usertags: timestamps
> X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
> 
> Hi,
> 
> Whilst working on the Reproducible Builds effort [0], we noticed that
> pkg-rocm-tools could not be built reproducibly.
> 
> This is because the generated manual page contains values based on the
> number of CPUs and amount of RAM on the system:
> 
> │ │ │ ├── ./usr/share/man/man1/rocm-qemu-run.1.gz
> │ │ │ │ │  .TP
> │ │ │ │ │  \fB\-m\fR MEM
> │ │ │ │ │ -Guest RAM (default: 60301)
> │ │ │ │ │ +Guest RAM (default: 60312)
> │ │ │ │ │  .HP
> 
> Patch attached that changes the output to deterministic text values —
> they remain dynamic defaults, however.
> 
>  [0] https://reproducible-builds.org/
> 
> 
> Regards,
>

--- End Message ---
Reply to: