[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Packaging composable_kernel



[Christian BAYLE]
> is completly cryptic for me, not extremely familiar with c++ template, 
> neither __device__ stuffs
> A small explanation or a documentation link, would be great
> how to fix this properly ?

I have no idea how to fix it properly, but now I have fetched the source
and had a look, and my #if proposal would look something like this:

diff --git a/include/ck/utility/f8_utils.hpp b/include/ck/utility/f8_utils.hpp
index 253307322..9159acf7e 100644
--- a/include/ck/utility/f8_utils.hpp
+++ b/include/ck/utility/f8_utils.hpp
@@ -183,6 +183,7 @@ In this case, the fp16 mantissa should be shift left by 1 */
     return (sign << (out_exp + out_mant)) | (out_exponent << out_mant) | mantissa;
 }
 
+#if 0 /* unused */
 template <typename X, typename Y, bool negative_zero_nan>
 __host__ __device__ Y run_cast_from_f8(X x)
 {
@@ -265,6 +266,7 @@ __host__ __device__ Y run_cast_from_f8(X x)
     retval = (sign << (out_exp + out_mant)) | (exponent << out_mant) | mantissa;
     return bit_cast<Y>(retval);
 }
+#endif /* unused */
 
 } // namespace
 

I have not tired to build the code.  Given that this is in a C++ header
file, other parts of the code might include and use this method, so it
might not work to drop it like this.  I suspect a easier way forward
might be to drop -Werror.

-- 
Happy hacking
Petter REinholdtsen


Reply to: