[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1088810: marked as done (pytorch: FTBFS with Make 4.4.1)

Your message dated Fri, 27 Dec 2024 06:05:06 +0000
with message-id <E1tR3T8-002oX1-HH@fasolo.debian.org>
and subject line Bug#1088810: fixed in pytorch 2.5.1+dfsg-3
has caused the Debian Bug report #1088810,
regarding pytorch: FTBFS with Make 4.4.1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1088810: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1088810
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: pytorch
Version: 2.5.1+dfsg-1
Severity: important
Tags: ftbfs patch

Dear Maintainer,

pytorch fails to build from source with Make 4.4.1 because of changes
in $(shell) handling. The attached patch fixes this by avoiding the
use of $(shell) when calculating flags.

Make 4.4.1 is currently available in experimental and will hopefully
soon be uploaded to unstable, at which time this bug will become
critical.

The attached patch is also included in a merge request which addresses
other issues in debian/rules too,
https://salsa.debian.org/deeplearning-team/pytorch/-/merge_requests/4

Regards,

diff --git a/debian/rules b/debian/rules
index b6a9f7af..d48e3fbd 100755
--- a/debian/rules
+++ b/debian/rules
@@ -9,6 +9,11 @@ export PYTORCH_VERSION = $(shell echo "$(DEB_VERSION_UPSTREAM)" | sed -e 's/+dfs
 export SOVERSION = 2.5
 export PATCH = 1
 
+include /usr/share/dpkg/buildflags.mk
+ORIG_CFLAGS := $(CFLAGS)
+ORIG_CPPFLAGS := $(CPPFLAGS)
+ORIG_CXXFLAGS := $(CXXFLAGS)
+
 # --[[ maintainer notes ]]--
 # How to dump the flags for the upstream built instance:
 # $ python3 -c 'import torch as th; print(th.__version__, th.__config__.show())'
@@ -35,12 +40,12 @@ export LD=ld
 export __LD=
 endif
 endif
-export CFLAGS = $(shell dpkg-buildflags --get CPPFLAGS) \
-                $(shell dpkg-buildflags --get CFLAGS) \
-                -gsplit-dwarf $(_WNOERROR_) $(__LD) -I/usr
-export CXXFLAGS = $(shell dpkg-buildflags --get CPPFLAGS) \
-                  $(shell dpkg-buildflags --get CXXFLAGS) \
-                  -gsplit-dwarf $(_WNOERROR_) $(__LD) -I/usr
+export CFLAGS := $(ORIG_CPPFLAGS) \
+                 $(ORIG_CFLAGS) \
+                 -gsplit-dwarf $(_WNOERROR_) $(__LD) -I/usr
+export CXXFLAGS := $(ORIG_CPPFLAGS) \
+                   $(ORIG_CXXFLAGS) \
+                   -gsplit-dwarf $(_WNOERROR_) $(__LD) -I/usr
 export ONNX_NAMESPACE = onnx
 export REL_WITH_DEB_INFO = ON
 export USE_GFLAGS= OFF
@@ -150,8 +155,8 @@ endif
 # Customization options (You may want to rebuild this package locally)
 NATIVE :=
 ifneq (,$(NATIVE))
-export CFLAGS = $(shell dpkg-buildflags --get CPPFLAGS) $(shell dpkg-buildflags --get CFLAGS) -gsplit-dwarf -march=native
-export CXXFLAGS = $(shell dpkg-buildflags --get CPPFLAGS) $(shell dpkg-buildflags --get CXXFLAGS) -gsplit-dwarf -march=native
+export CFLAGS := $(ORIG_CPPFLAGS) $(ORIG_CFLAGS) -gsplit-dwarf -march=native
+export CXXFLAGS := $(ORIG_CPPFLAGS) $(ORIG_CXXFLAGS) -gsplit-dwarf -march=native
 endif

--- End Message ---
--- Begin Message --- 
Source: pytorch
Source-Version: 2.5.1+dfsg-3
Done: Mo Zhou <lumin@debian.org>

We believe that the bug you reported is fixed in the latest version of
pytorch, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1088810@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mo Zhou <lumin@debian.org> (supplier of updated pytorch package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 27 Dec 2024 00:36:00 -0500
Source: pytorch
Architecture: source
Version: 2.5.1+dfsg-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Deep Learning Team <debian-ai@lists.debian.org>
Changed-By: Mo Zhou <lumin@debian.org>
Closes: 1088810 1090052 1090053
Changes:
 pytorch (2.5.1+dfsg-3) unstable; urgency=medium
 .
   [ Stephen Kitt ]
   * Escape $ symbols in sed commands (Closes: #1088810)
   * debian/rules: avoid $(shell) where possible
 .
   [ Mo Zhou ]
   * Autopkgtest: mark inline_container_test as flaky.
   * Refresh autopkgtest control file.
   * Add notes to d/rules for python3 support -- we only support one single
     python3 version, due to libtorch_python.so is built against a specific
     version and conflicts with other versions.
   * d/rules: Correct llvm-config version.
   * d/control: Add the missing B-D libzstd-dev.
   * Fix missing error trapping in Makefiles. (Closes: #1090052)
   * [trivial] rules: Replace spaces into tabs for consistent formatting.
   * rules: Only install necessary shared objects. (Closes: #1090053)
Checksums-Sha1:
 dd93211be01c588d17fa8051b4f51264cbc11b0c 3483 pytorch_2.5.1+dfsg-3.dsc
 0d5f9a2edaf4986160aafc59d2acc069977ee71e 209576 pytorch_2.5.1+dfsg-3.debian.tar.xz
 c1245edd3ce091030a71e595225541a1e02213af 10213 pytorch_2.5.1+dfsg-3_source.buildinfo
Checksums-Sha256:
 4f69797ca4d63bb0b964c8f3955772ac17c08892443ddcacf79cfe9bda41d22e 3483 pytorch_2.5.1+dfsg-3.dsc
 299931f9206bacc4c25817f7a4db1e99b7a0cde0f5fcfdd3b5ca6fc5cbcbc092 209576 pytorch_2.5.1+dfsg-3.debian.tar.xz
 7b611b2d9c88f90907e9f2672754be5b0cbde00528da30685684d736a26ab2c7 10213 pytorch_2.5.1+dfsg-3_source.buildinfo
Files:
 f1530069b69b9dac7a78978c7230aa3a 3483 science optional pytorch_2.5.1+dfsg-3.dsc
 514fb544e225b5ce35510a9b798cad98 209576 science optional pytorch_2.5.1+dfsg-3.debian.tar.xz
 6e2ee41813b1e192a78e9ffe65c66cd0 10213 science optional pytorch_2.5.1+dfsg-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEEY4vHXsHlxYkGfjXeYmRes19oaooFAmduPeIRHGx1bWluQGRl
Ymlhbi5vcmcACgkQYmRes19oaoq/ng/6A+MZJnGCH13aysMbGuoHRiH9Np0jcb4+
43f3rU39LfORj+ZYQlQkjfcFeDLLPSZ/FuFtxlKtGEBGTmgTGqHWnNmrvQSsyPlu
mFjnTqoasTJEgTzB7QAedsGbDWcA0eFaq86r7bW3lG8vmeOSwJmTiB4CcVmwwveG
k517UkWb4/iOIHgBfBXUcHmFyX6bgIYuNE1LnWK6oBmJiPsNZUIpXiGAWz4FwS9p
PyhmeN5nr13pm/L2Lu6VF2TiRuy/gEyeF3hcYcaGjUlpYouKuEp9+01bSzlYswyi
UVPZWsW55ShI2NkcR7Su0xAxmEWDJT8X+BC4E+87nx5+McAuVWoISK0Jk1ob+0f2
XCEb0SkINA9YeuC5Ge/mc9l0wzqYzrJvLZPSkS3Frrdea2J5LMlrUOnYt8rC03+z
ph1cVW7sfgBhiWTgXlBET/GBnR5ds0aznLgRjhAqSZkRXnbkKpRl7BgEK6XQdbTK
vgJTB2N2YmQrc8EmoLujv6h52d3u0HOuxyJKRdfvye3LiNkCGHqZ48BwivOwoaLb
7bBnNaPWZg7f+BjYQ/7CRkIwm4PiqaXijPDzeBDBued8GBz8naxu3EXrCtahDpIm
EPtJRso3nwWD7EVUi3ZDGGHJm55xZbnAdTaOO5Sjlvq1dHamXj2kzXY0OmQf4B23
n7+Z/DyFbek=
=Mjfp
-----END PGP SIGNATURE-----

Attachment: pgpvyZGKC279C.pgp
Description: PGP signature


--- End Message ---
Reply to: