Re: Massive symbol file changes in dpkg-gensymbols
On 11/24/24 04:09, Christian Kastner wrote:
Hi Xuanteng, Mo,
On 2024-11-23 09:48, Xuanteng Huang wrote:
On Nov 21, 2024, at 10:52, Mo Zhou <lumin@debian.org> wrote:
We can potentially patch the upstream code with version script to hide
those internal interfaces with a wildcard.
Thansk for your suggestions, and I’ve followed this to hide all unnecessary symbols for librocm-smi [4].
[4]: https://salsa.debian.org/rocm-team/rocm-smi-lib/-/merge_requests/5
Just to double-check: this only filters out local symbols and has no
other side effects, and that's what we want, right?
Yes. Unless an external library wants to call those internal APIs.
With this implying that, should symbols change between versions, our
dpkg-gensymbols would catch this, and an incompatible change would
trigger a SOVER bump.
As long as we are hiding the internal APIs that are not intended to
be used by any external code, I see no necessity to bump the SOVERSION --
it wastes human time and there is no harm to hide symbols that nobody
should use and has never used.
If we're all in agreement, then this is good and should also be
submitted upstream.
I agree we can ask the upstream to see how they think about this.
Reply to: