[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New src:rocm-compiler for hipcc, comgr and device-libs



Hi Christian and Cory,

On 9/9/24 06:10, Christian Kastner wrote:
> In d/copyright, Files-Excluded removes some assemblies and binaries. Can
> you assess the impact of this?

As the excluded file paths say, these assemblies and binaries are used for test. For the binaries, I think they're used to test the LLVM amdgpu code object V2/V3 [6]. For assemblies, the CMakeLists.txt says they're used to generate the test binary executables [7]. As we currently disable the test building for comgr, I think the exclusion may not have substantial effects.

On 9/16/24 05:02, Christian Kastner wrote:
> Some other thing that I noticed reviewing just now: rocm-hipamd
> currently also ships:
>  * libamdhip64-5
>  * libamdhip64-dev
>  * libhiprtc-builtins5
>  * libamhip64-doc
> The new package does not. If I understand the situation correctly, this
> is because 6.1 works against upstream LLVM directly, right?

Note that this new package (rocm-llvm) is not going to replace the role of rocm-hipamd. The libamdhip64* library is shipped from the new upstream repository named clr [8] (we'll work on this after rocm-llvm). For 6.1.2, this new rocm-llvm package provides compiler components while the clr offers runtime parts. I think AMD is doing this to separate the runtime and compiler into different codebases.

That's say, the hipamd upstream [9] is split into two parts: rocm-clr [8] (runtime) + rocm-llvm(compiler).

On 9/16/24 05:02, Christian Kastner wrote:
> Agreed. Since this is a pretty major change, we'll need these tests to quickly discover if things went alright.

Yes, I'm working on this.

Best,
Xuanteng

[6]: https://salsa.debian.org/xuantengh/rocm-compiler/-/blob/master/amd/comgr/test/CMakeLists.txt?ref_type=heads#L115-116
[7]: https://salsa.debian.org/xuantengh/rocm-compiler/-/blob/master/amd/comgr/test/CMakeLists.txt?ref_type=heads#L89-109
[8]: https://github.com/ROCm/clr
[9]: https://github.com/ROCm/hipamd


Reply to: