[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: roct-thunk-interface_6.1.2-1~exp1_source.changes ACCEPTED into experimental



Hi Christian,

On 2024-08-20 12:05, Christian Kastner wrote:
During review, I noticed there there is a tests/ directory that we don't
make use of yet. Cory, would you happen to know if this is a goal we
should pursue?

I've been discussing this further with Tom Rix and Jeremy Newton. The kfdtest utility in that subdirectory is a test suite for the KFD component in the kernel. I think it would therefore be useful to have it available for autopkgtests.

The kfdtest license does state that it depends on libamdsp3.a [1], which has a non-free license. However, that comment is at least four years old and I can find no other mention of libamdsp3 in the repository. Tom has opened an issue upstream to resolve that matter [2].

On 2024-08-20 13:04, Cordell Bloor wrote:
The roct-thunk-interface library is being merged into rocr-runtime in the next upstream release. I wouldn't worry about those sorts of package enhancements until the dust settles on the upstream reorganization.

I've reviewed the combined repository and the kfdtest utility is still included. AFAICT, the roct-thunk-interface source tree is just moving to a subdirectory of the rocr-runtime. As such, I withdraw my statement. The tests would be useful and there's no need to wait.

Sincerely,
Cory Bloor

[1]: https://salsa.debian.org/rocm-team/roct-thunk-interface/-/blob/debian/6.1.2-1_exp1/tests/kfdtest/LICENSE.kfdtest?ref_type=tags#L30
[2]: https://github.com/ROCm/ROCT-Thunk-Interface/issues/109


Reply to: