[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Should we include the LLVM code into the source package for comgr, device-libs and hipcc?



Hi developers,

I’m attempting to update ROCm to upstream version 6.1.2. The upstream reorganizes the layout of comgr, device-libs and hipcc packages and now they are located in the AMD forked LLVM repository [1]. So we may choose to maintain src:rocm-llvm and provide bin:rocm-device-libs, bin:rocm-comgr and bin:hipcc, as discussed in the release plan [2].

Note in the upstream repository [1], they are maintained as standalone projects, i.e., they can be built individually in the absence of the overall LLVM codebase. And it’s reasonable for us to choose the official existing LLVM in Debian to build them,  instead of using the LLVM forked by AMD.

So here comes the question: should we include the “useless” large LLVM codebase in the src:rocm-llvm package? As we prefer to use the Debian LLVM rather than AMD LLVM to build the binary packages, can we just strip them out of the source package and keep only the “amd” directory? Besides, for the LLVM team, they keep only the “debian” folder rather than the entire LLVM codebase [3] (not sure why they do so). So we should consider the organization of the src:rocm-llvm package (or even its name).

Best,
Xuanteng

[1]: https://github.com/ROCm/llvm-project/tree/rocm-6.1.2/amd
[2]: https://salsa.debian.org/rocm-team/community/team-project/-/wikis/rocm-6.1-release-plan
[3]: https://salsa.debian.org/pkg-llvm-team/llvm-toolchain


Reply to: