[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1061623: marked as done (rocblas: Switch libmsgpack-dev to libmsgpack-cxx-dev)

Your message dated Fri, 02 Feb 2024 23:02:11 +0000
with message-id <E1rW2Xz-00DSqz-FY@fasolo.debian.org>
and subject line Bug#1061623: fixed in rocblas 5.5.1+dfsg-4
has caused the Debian Bug report #1061623,
regarding rocblas: Switch libmsgpack-dev to libmsgpack-cxx-dev
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1061623: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061623
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: rocblas
Version: 5.5.1+dfsg-3
Severity: normal
Tags: patch
Control: block 1018679 by -1

Dear maintainer,

libmsgpack-dev's C++ bindings were split out to a separate binary
package -- libmsgpack-cxx-dev -- in 4.1.1-1 to follow upstream's
separation of the project. rocblas Build-Depends on libmsgpack-dev and
uses the C++ library, so it needs to switch to libmsgpack-cxx-dev.

The pending 6.x version of msgpack-cxx (currently in experimental) also
changed the CMake config name to msgpack-cxx.  This has been accounted
for upstream.

I've attached a patch which addresses both of these points.

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'testing'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.6.13-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

diffstat for rocblas-5.5.1+dfsg rocblas-5.5.1+dfsg

 control                                |    2 -
 patches/0020-msgpack-names.patch       |   22 ++++++++++++++++++++
 patches/0021-msgpack-cxx-support.patch |   35 +++++++++++++++++++++++++++++++++
 patches/series                         |    2 +
 5 files changed, 67 insertions(+), 1 deletion(-)

diff -Nru rocblas-5.5.1+dfsg/debian/control rocblas-5.5.1+dfsg/debian/control
--- rocblas-5.5.1+dfsg/debian/control	2023-09-19 04:28:14.000000000 -0400
+++ rocblas-5.5.1+dfsg/debian/control	2024-01-27 09:04:18.000000000 -0500
@@ -21,7 +21,7 @@
                rocminfo,
                patchelf,
                rocm-cmake (>= 5.3.0),
-               libmsgpack-dev,
+               libmsgpack-cxx-dev,
                libblas-dev,
                libgtest-dev
 Build-Depends-Indep: dh-sequence-sphinxdoc <!nodoc>,
diff -Nru rocblas-5.5.1+dfsg/debian/patches/0020-msgpack-names.patch rocblas-5.5.1+dfsg/debian/patches/0020-msgpack-names.patch
--- rocblas-5.5.1+dfsg/debian/patches/0020-msgpack-names.patch	1969-12-31 19:00:00.000000000 -0500
+++ rocblas-5.5.1+dfsg/debian/patches/0020-msgpack-names.patch	2024-01-27 09:04:20.000000000 -0500
@@ -0,0 +1,22 @@
+From c1fa5b358d8cbe601754ef5ea4b695d895a34f62 Mon Sep 17 00:00:00 2001
+From: Torre Zuk <42548444+TorreZuk@users.noreply.github.com>
+Date: Tue, 28 Nov 2023 09:02:43 -0700
+Subject: [PATCH] fix for newer windows vcpkg msgpack (#1827)
+
+---
+ Tensile/Source/lib/CMakeLists.txt | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Tensile/Source/lib/CMakeLists.txt b/Tensile/Source/lib/CMakeLists.txt
+index f8cc527c83..d3f4b697fb 100644
+--- a/tensile/Tensile/Source/lib/CMakeLists.txt
++++ b/tensile/Tensile/Source/lib/CMakeLists.txt
+@@ -98,7 +98,7 @@ if(TENSILE_USE_LLVM OR TENSILE_USE_MSGPACK)
+ endif()
+ 
+ if(TENSILE_USE_MSGPACK)
+-    find_package(msgpack REQUIRED)
++    find_package(msgpack REQUIRED NAMES msgpack msgpack-c)
+     target_compile_definitions(TensileHost PUBLIC -DTENSILE_MSGPACK=1)
+ 
+     if(TARGET msgpackc-cxx)
diff -Nru rocblas-5.5.1+dfsg/debian/patches/0021-msgpack-cxx-support.patch rocblas-5.5.1+dfsg/debian/patches/0021-msgpack-cxx-support.patch
--- rocblas-5.5.1+dfsg/debian/patches/0021-msgpack-cxx-support.patch	1969-12-31 19:00:00.000000000 -0500
+++ rocblas-5.5.1+dfsg/debian/patches/0021-msgpack-cxx-support.patch	2024-01-27 09:04:20.000000000 -0500
@@ -0,0 +1,35 @@
+From 0d942a6a8bfa8557171716dbcc1236adc806c9c5 Mon Sep 17 00:00:00 2001
+From: Torre Zuk <42548444+TorreZuk@users.noreply.github.com>
+Date: Wed, 6 Dec 2023 13:14:49 -0700
+Subject: [PATCH] another vcpkg version package name fix (#1836)
+
+* more vcpkg package options
+
+---------
+
+Co-authored-by: Zuk <torrezuk@amd.com>
+---
+ Tensile/Source/lib/CMakeLists.txt | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/Tensile/Source/lib/CMakeLists.txt b/Tensile/Source/lib/CMakeLists.txt
+index d3f4b697fb..3fa647d6ec 100644
+--- a/tensile/Tensile/Source/lib/CMakeLists.txt
++++ b/tensile/Tensile/Source/lib/CMakeLists.txt
+@@ -98,13 +98,15 @@ if(TENSILE_USE_LLVM OR TENSILE_USE_MSGPACK)
+ endif()
+ 
+ if(TENSILE_USE_MSGPACK)
+-    find_package(msgpack REQUIRED NAMES msgpack msgpack-c)
++    find_package(msgpack REQUIRED NAMES msgpack msgpack-cxx msgpack-c)
+     target_compile_definitions(TensileHost PUBLIC -DTENSILE_MSGPACK=1)
+ 
+     if(TARGET msgpackc-cxx)
+         get_target_property(msgpack_inc msgpackc-cxx INTERFACE_INCLUDE_DIRECTORIES)
+     elseif(TARGET msgpackc)
+         get_target_property(msgpack_inc msgpackc INTERFACE_INCLUDE_DIRECTORIES)
++    elseif(TARGET msgpack-cxx)
++        get_target_property(msgpack_inc msgpack-cxx INTERFACE_INCLUDE_DIRECTORIES)
+     endif()
+ 
+     if(DEFINED msgpack_inc)
diff -Nru rocblas-5.5.1+dfsg/debian/patches/series rocblas-5.5.1+dfsg/debian/patches/series
--- rocblas-5.5.1+dfsg/debian/patches/series	2023-09-19 04:28:14.000000000 -0400
+++ rocblas-5.5.1+dfsg/debian/patches/series	2024-01-27 09:04:20.000000000 -0500
@@ -17,3 +17,5 @@
 0017-print-kernel-name-for-missing-attribute-error.patch
 0018-verbose-tensile-source-kernel-build.patch
 0019-remove-x86-intrinsics.patch
+0020-msgpack-names.patch
+0021-msgpack-cxx-support.patch

--- End Message ---
--- Begin Message --- 
Source: rocblas
Source-Version: 5.5.1+dfsg-4
Done: Christian Kastner <ckk@debian.org>

We believe that the bug you reported is fixed in the latest version of
rocblas, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1061623@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Christian Kastner <ckk@debian.org> (supplier of updated rocblas package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 02 Feb 2024 14:18:29 +0100
Source: rocblas
Architecture: source
Version: 5.5.1+dfsg-4
Distribution: unstable
Urgency: medium
Maintainer: Debian ROCm Team <debian-ai@lists.debian.org>
Changed-By: Christian Kastner <ckk@debian.org>
Closes: 1061623
Changes:
 rocblas (5.5.1+dfsg-4) unstable; urgency=medium
 .
   [ Christian Kastner ]
   * autopkgtest: Export dmesg and other info as artifacts
 .
   [ James McCoy ]
   * Switch libmsgpack-dev to libmsgpack-cxx-dev. (Closes: #1061623)
Checksums-Sha1:
 fe8ac40e6ee9b28eddb573fffec573b0e494b16e 3172 rocblas_5.5.1+dfsg-4.dsc
 3150d31bdfbe02d8a804bfdb8f06bccad889dbd9 369768 rocblas_5.5.1+dfsg-4.debian.tar.xz
 a6db5cc8d2af95dd7abdd09da8d2214da96d8b1c 7443 rocblas_5.5.1+dfsg-4_source.buildinfo
Checksums-Sha256:
 1088497f80e1d9ec294dd491bfbe08038dfe2d3f4013ef7476cebc3db0ce3f5b 3172 rocblas_5.5.1+dfsg-4.dsc
 dab5982df844a7996a9bf2429d903ae663bf6aa846cccb0267aef26485476c0a 369768 rocblas_5.5.1+dfsg-4.debian.tar.xz
 acb396e883fe810bee72363709d06557119a74aad5e39e33717c4c9651c0d709 7443 rocblas_5.5.1+dfsg-4_source.buildinfo
Files:
 dfc1b6ada0abdbf41166750d3a58b9a4 3172 devel optional rocblas_5.5.1+dfsg-4.dsc
 42a668f050ae8b0cd590b7cd8b7d596a 369768 devel optional rocblas_5.5.1+dfsg-4.debian.tar.xz
 731ffd577e3dba7341b4475d00245701 7443 devel optional rocblas_5.5.1+dfsg-4_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEQZ9+mkfDq5UZ8bCjOZU6N95Os2sFAmW9a0wACgkQOZU6N95O
s2stzhAAvYAFmUT9xj4vL9Wf/lT6dbE+HZpObju+9VZPUfFOsFEDn+ZimAnhgJZs
0CGzfO1RKx58DWrBik7cF2aei+8kBqoc+imxWyIZc5xQOOqfzwZ1JlKC9FbOOzkb
8lXfbThgbKBEDDXM3r9Um5fzmyJsY1dl6qLYJd2l2srBRb6UAu1XIGaJ7C1YJk3o
ht1I6urzxBRe09wmbMa/EGHzjXrQsOFvjiGCJbH08SG4jGGXrTLUIKJ2MiEPVCGw
9oxp2rMjk5TWr648ttIPXQa7Xte4s1cmtpFtMcBBcUDoP8BEf+jXbhtZx1MlPDWC
I+bPfb8fmfClvpsYxwP+VwEMXmSVldWe6NFt1vc/UtLEIHLUcf3MOnOk9Q3PcZCA
knUDA36LI9TtLJ6ErTD06gybS4Jd332ep3JB46pCfUGPiQjPS0+Jdrphyv1xmhpk
3uiwN6HxW8jwbnaJg2DpyN/uQMXntLKt28RO9TsKLFk8GZayyB479mmmv1vyW3YL
cxjXrxS3GBsfLGpzshqH7+LuxxZ7wWVWZWatCUHFax1gNR/78JD4q2xaL8XmJOxY
XoTo9Xph6UlCrUjA0M3FDHmZc+BDonUsAyp5DqsC5+BBavjeviKmJ/W9ZEGAy/l2
j3ZNWrbInyBsRyn35oGk9xrvi7j++pMwyknrbUUlGNBrZSKV5So=
=8Gls
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: