Re: Updating rocr-runtime to 5.7.1

[Cordell Bloor <cgmb@slerp.xyz>]

Hi Christian,

On 2023-11-26 14:25, Christian Kastner wrote:
> On 2023-11-26 06:55, Cordell Bloor wrote:
> > I was updating rocr-runtime from 5.2.3 to 5.7.1, but it seems that there
> > were some precompiled shaders introduced in 5.3.0. I'm trying to find
> > more information about these binary blobs [1].
> rocr-runtime is a good example for the "schedule transitive
> dependencies?" question I created an issue for [1].
>
> rocr-runtime builds libhsa-runtime64-1, which only has two other reverse
> dependencies:
>   * libamdhip64-5 (src: rocm-hipamd)
>   * rocminfo (src: rocminfo)
>
> Given a new rocr-runtime upload, our current scheduler would only test
> the above reverse dependencies, because all other packages depend on in
> indirectly, through libamdhip64-5.
>
> Two solutions come to mind:
>    (1) We use the new "trigger" feature of the recently updated scheduler
>        to trigger all other dependencies on rocr-runtime uploads
>    (2) We schedule all reverse dependencies transitively, with the first
>        non-ROCm packages being the terminators (we test them, but not
>        their reverse dependencies)

The cost of doing (2) for the ROCm packages seems pretty reasonable. The 
ROCm packages don't get updated all that often, and the information 
provided by these tests would be valuable in catching problems when they 
are introduced.

Everything else being equal, I would favour (2).

Sincerely,
Cory Bloor