[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1057643: onednn: add support for loongarch64



On Wed, 2023-12-06 at 20:35 +0800, zhangdandan wrote:
> Source: onednn
> Version: 2.7.4-2
> Severity: wishlist
> Tags: patch
> User: debian-loongarch@lists.debian.org
> Usertags: loong64
> 
> Dear maintainers,
> 
> The onednn source package lacks LoongArch architecture support.
> We need to add loongarch64 support in d/control and source code.
> 
> Please consider the patch I have attached.
> The onednn source package was compiled successfully on my local
> loong64 
> rootfs environment.

Hi, I just saw this patch flying by and looked into it (I'm not a
maintainer for this package).

The following lines are very likely not correct:

++ # For native compilation tune for the host processor
++            if (CMAKE_SYSTEM_PROCESSOR STREQUAL
CMAKE_HOST_SYSTEM_PROCESSOR)
++                append(DEF_ARCH_OPT_FLAGS "-march=native")
++            endif()

We must not compile with -march=native, as this makes the build
dependent on the build machine. By that it is neither portable nor
reproducible anymore.

Felix

> And the test cases passed, for examples,
> ```
> ......
> 101/101 Test #101: noexcept-cpp
> .....................................   
> Passed    0.00 sec
> 100% tests passed, 0 tests failed out of 101
> Total Test time (real) = 177.87 sec
> ```
> If you have any questions, you can contact me at any time.
> 
> thanks,
> Dandan Zhang
> 


Reply to: