Re: ROCm CI: Now also triggering on dependency changes
Hey Cory,
On 2023-12-04 07:50, Cordell Bloor wrote:
> I know of two lists that could be used for that purpose [1][2]. I'm
> not sure which one is better.
These are *very* useful. Thanks!
I would have simply attempted to map the known IDs, but this is much
cleaner and robust.
> Perhaps you could emit a tmpfail when the device being passed through
> is known to be the wrong architecture, but merely emit a warning when
> the device architecture is unknown (i.e., do not emit an error)? That
> would provide a safety net for common errors without getting in the
> way when new hardware is added. Or, maybe default to tmpfail for
> unknown hardware, but add a configuration option to disable the check.
Yeah, that makes sense. Will do.
Best,
Christian
> [1]:
> https://github.com/RadeonOpenCompute/rocminfo/blob/rocm-5.7.1/rocm_agent_enumerator#L12-L75
> [2]:
> https://github.com/ROCmSoftwarePlatform/hipfort/blob/rocm-5.7.1/bin/gputable.txt
--
Christian Kastner
Reply to: