[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ROCm bump to 5.7 - rocm-smi-lib SOVERSIONs bump



Thanks. I'll also help bumping some packages to 5.7.0 in experimental.

On Sun, 2023-09-17 at 11:25 +0200, Étienne Mollier wrote:
> 
> Or through c++filt:
> 
> 	- shared_mutex_init(char const*, unsigned int)@Base 4.5.2
> 	+ shared_mutex_init(char const*, unsigned int, bool)@Base
> 5.7.0
> 
> This symbol change is leaked from the third party shared_mutex
> library, which has probably seen a version bump in the middle.
> It is present in the rocm_smi64 library, but also in the oam
> library which has /not/ seen an SOVERSION bump upstream.
> 
> I'm not certain this symbol is supposed to be exposed by these
> libraries anyway, but I guess it wont hurt to be on the safe
> side.  Is it okay if I align the rocm_smi64 SOVERSION to 5, and
> also bump the oam SOVERSION to, say, 2, to reflect this
> signature change?

A very straightforward way to confirm this is to grep the pattern
  shared_mutex_init
within the source code of its reverse dependencies. If there is no
package directly calling this API, then it is fine to go ahead
without SOVERSION bump.


Reply to: