[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1036522: pytorch-audio: reproducible-builds: build paths trigger differences



Source: pytorch-audio
Severity: normal
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

The RPATH contains the build path resulting in different buildid and
various other differences:

  https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/pytorch-audio.html

The attached patch to the upstream tools/setup_helpers/extension.py
fixes this by passing -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON to CMake.

With this patch applied, based on my local tests, pytorch-audio should
build reproducibly on tests.reproducible-builds.org!

Thanks for maintaining pytorch-audio!

live well,
  vagrant
From 8e7dab52b12566c95569581c3f81ac7689b5e179 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant@reproducible-builds.org>
Date: Sun, 21 May 2023 14:20:35 -0700
Subject: tools/setup_helpers/extension.py: Pass
 -DCMAKE_BUILD_RPATH_USE_ORIGIN=ON to CMake.

https://tests.reproducible-builds.org/debian/issues/unstable/cmake_rpath_contains_build_path_issue.html
---
 tools/setup_helpers/extension.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/setup_helpers/extension.py b/tools/setup_helpers/extension.py
index 96ea13e..6ac1538 100644
--- a/tools/setup_helpers/extension.py
+++ b/tools/setup_helpers/extension.py
@@ -100,6 +100,7 @@ class CMakeBuild(build_ext):
             f"-DCMAKE_PREFIX_PATH={torch.utils.cmake_prefix_path}",
             f"-DCMAKE_INSTALL_PREFIX={extdir}",
             "-DCMAKE_VERBOSE_MAKEFILE=ON",
+            "-DCMAKE_BUILD_RPATH_USE_ORIGIN=ON",
             f"-DPython_INCLUDE_DIR={distutils.sysconfig.get_python_inc()}",
             f"-DBUILD_SOX:BOOL={'ON' if _BUILD_SOX else 'OFF'}",
             f"-DBUILD_KALDI:BOOL={'ON' if _BUILD_KALDI else 'OFF'}",
-- 
2.39.2

Attachment: signature.asc
Description: PGP signature


Reply to: