[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: rocprim review (Was: rocprim and rocthrust copyright review)



Hi Cordell,

Cordell Bloor, on 2022-11-06:
> On 2022-11-04 14:08, Étienne Mollier wrote:
> > I've gotten to run the test suite on gfx1030, but I see test
> > failures affecting sorting routines:
> > 
> > 	 14 - rocprim.block_sort (Failed)
> > 	 28 - rocprim.device_segmented_radix_sort (Failed)
> > 	 44 - rocprim.warp_sort (Failed)
> 
> After applying a patch from rocprim upstream [1], the full test suite passed
> on gfx906.

Awesome, I confirm tests pass on gfs1030 as well.  I let you
finalize the packaging to include the patch, and I'll try to
upload tomorrow evening (or apply myself if you're short on time
for this one).

> [1]: https://github.com/ROCmSoftwarePlatform/rocPRIM/commit/36a4d355b3ff1d6d64a7c308d0a0798a855679c3.patch

Have a nice day,  ;)
-- 
Étienne Mollier <emollier@emlwks999.eu>
Fingerprint:  8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
Sent from /dev/pts/2, please excuse my verbosity.

Attachment: signature.asc
Description: PGP signature


Reply to: