[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1022797: librocm-smi-dev: find_package(rocm_smi) fails due to missing liboam



Hi Cory,

Cordell Bloor, on 2022-10-26:
> The oam target code is generated by CMake, but it appears to be exported by
> this line here: https://github.com/RadeonOpenCompute/rocm_smi_lib/blob/rocm-5.3.0/CMakeLists.txt#L183
> 
> (Incidentally, "rcom_smi_target.cmake" looks like a typo.)
> 
> I think we could probably create a patch that splits the rocm_smi and oam
> CMake config files. We'd remove oam from the rocm_smi exported targets and
> create an oam-config.cmake file, so it could be exported as its own thing.
> find_package(oam) would then be used to get the oam target.
> 
> To make Debian's behaviour compatible with upstream when both libraries are
> installed, we could modify the rocm_smi-config.cmake template
> (rocm_smi-config.cmake.in), so that find_package(rocm_smi) does a
> find_package(oam QUIET).

Some time ago, I tried to implement such a split, but to be
honest, my competency with cmake is not what it should be to
address the issue that way.  But knowing this is doable, I'm
neither enthusiastic about my "Recommends:" solution anymore.
I'm afraid I might stall that particular issue.

But thanks for the idea and the clues,
-- 
Étienne Mollier <emollier@emlwks999.eu>
Fingerprint:  8f91 b227 c7d6 f2b1 948c  8236 793c f67e 8f0d 11da
Sent from /dev/pts/2, please excuse my verbosity.

Attachment: signature.asc
Description: PGP signature


Reply to: