[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1012576: marked as done (onnx: FTBFS with protobuf 3.20.1+)

Your message dated Wed, 23 Nov 2022 09:50:06 +0200
with message-id <Y33QrtC+YMG/RLYe@localhost>
and subject line Fixed since 1.9.0
has caused the Debian Bug report #1012576,
regarding onnx: FTBFS with protobuf 3.20.1+
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1012576: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012576
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: onnx
Version: 1.7.0+dfsg-3.1
Severity: important
Usertags: protobuf3_20
Tags: ftbfs upstream bookworm sid patch

Hi,

I would like to start the Protobuf 3.20.1 transition in a few days.
Your package is currently FTBFS for a simple reason. The function
SetTotalBytesLimit doesn't have a second argument for long (protobuf
3.6) and it was ignored previously. Now it's finally removed and hence
your package doesn't build anymore.
As it was ignored for a long time, the fix is easy, just remove that
argument when calling the mentioned function. Patch is attached,
please apply it soon.

Thanks,
Laszlo/GCS

Description: fix Protobuf FTBFS
 SetTotalBytesLimit no longer has second argument.
Author: Laszlo Boszormenyi (GCS) <gcs@debian.org>
Forwarded: no
Last-Update: 2022-06-06

---

--- onnx-1.7.0+dfsg.orig/onnx/proto_utils.h
+++ onnx-1.7.0+dfsg/onnx/proto_utils.h
@@ -31,7 +31,7 @@ bool ParseProtoFromBytes(Proto* proto, c
   // respectively.
   ::google::protobuf::io::ArrayInputStream input_stream(buffer, static_cast<int>(length));
   ::google::protobuf::io::CodedInputStream coded_stream(&input_stream);
-  coded_stream.SetTotalBytesLimit((2048LL << 20) - 1, 512LL << 20);
+  coded_stream.SetTotalBytesLimit((2048LL << 20) - 1);
   return proto->ParseFromCodedStream(&coded_stream);
 }

--- End Message ---
--- Begin Message --- 
Version: 1.12.0-1~exp1

https://github.com/onnx/onnx/commit/d3bc82770474761571f950347560d62a35d519d7
https://buildd.debian.org/status/package.php?p=onnx

cu
Adrian

--- End Message ---
Reply to: