[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1007200: marked as done (pytorch: FTBFS with glog 0.6.0+)



Your message dated Tue, 22 Mar 2022 20:37:09 +0000
with message-id <E1nWlFd-0001o2-Ms@fasolo.debian.org>
and subject line Bug#1007200: fixed in pytorch 1.8.1-5
has caused the Debian Bug report #1007200,
regarding pytorch: FTBFS with glog 0.6.0+
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1007200: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1007200
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: pytorch
Version: 1.8.1-4
Severity: normal
Tags: ftbfs sid patch

Hi,

I've already uploaded the new google-glog 0.6.0 release candidate
version to experimental. It makes IsGoogleLoggingInitialized() a
public function. Your package needs to be updated to use it instead of
its hack. Patch is attached.
Please test your package and report back. I would like to start the
transition soon, but not break your package.

Regards,
Laszlo/GCS
Description: move IsGoogleLoggingInitialized() to public API
 It was an internal function and project used hacks to reach it. Now it's part
 of the public API.
Author: Laszlo Boszormenyi (GCS) <gcs@debian.org>
Forwarded: no
Last-Update: 2022-03-08

---

--- pytorch-1.8.1.orig/c10/util/Logging.cpp
+++ pytorch-1.8.1/c10/util/Logging.cpp
@@ -170,23 +170,13 @@ C10_DEFINE_int(
     google::GLOG_WARNING,
     "The minimum log level that caffe2 will output.");
 
-// Google glog's api does not have an external function that allows one to check
-// if glog is initialized or not. It does have an internal function - so we are
-// declaring it here. This is a hack but has been used by a bunch of others too
-// (e.g. Torch).
-namespace google {
-namespace glog_internal_namespace_ {
-bool IsGoogleLoggingInitialized();
-} // namespace glog_internal_namespace_
-} // namespace google
-
 namespace c10 {
 bool InitCaffeLogging(int* argc, char** argv) {
   if (*argc == 0)
     return true;
 #if !defined(_MSC_VER)
   // This trick can only be used on UNIX platforms
-  if (!::google::glog_internal_namespace_::IsGoogleLoggingInitialized())
+  if (!::google::IsGoogleLoggingInitialized())
 #endif
   {
     ::google::InitGoogleLogging(argv[0]);

--- End Message ---
--- Begin Message ---
Source: pytorch
Source-Version: 1.8.1-5
Done: Mo Zhou <lumin@debian.org>

We believe that the bug you reported is fixed in the latest version of
pytorch, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1007200@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mo Zhou <lumin@debian.org> (supplier of updated pytorch package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 22 Mar 2022 15:56:16 -0400
Source: pytorch
Architecture: source
Version: 1.8.1-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Deep Learning Team <debian-ai@lists.debian.org>
Changed-By: Mo Zhou <lumin@debian.org>
Closes: 1007200
Changes:
 pytorch (1.8.1-5) unstable; urgency=medium
 .
   * Patch for compatibility with glog 0.6.0+. (Closes: #1007200)
Checksums-Sha1:
 f734b74ad753ca293ad7085ce4ab5d0091c2bc52 3323 pytorch_1.8.1-5.dsc
 3f5c8bc714efba8c8a3f523bc1f4b5d4c7139ed8 57560 pytorch_1.8.1-5.debian.tar.xz
 4247dc8ac572d3d02045a62bb6e16f5f87789666 7844 pytorch_1.8.1-5_source.buildinfo
Checksums-Sha256:
 ae487e05a5ac7fd8844f1b99650aaf4ba8e326df7b1e32cc5748aea3874754db 3323 pytorch_1.8.1-5.dsc
 0b10af7bda493d277cd7ae7c819d9ecd953303237af6d0c8950da76077075c66 57560 pytorch_1.8.1-5.debian.tar.xz
 65353725c782b18577de95ca6f04ca0b54ae9052492177c3fcafb89e8302e76f 7844 pytorch_1.8.1-5_source.buildinfo
Files:
 3493b332a92a2ae914f27d6ebb4c8953 3323 science optional pytorch_1.8.1-5.dsc
 6a7a562631221beb4c8f0004a2c61682 57560 science optional pytorch_1.8.1-5.debian.tar.xz
 9b1c958a29ab763e06e27268e559ca25 7844 science optional pytorch_1.8.1-5_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEEY4vHXsHlxYkGfjXeYmRes19oaooFAmI6KkARHGx1bWluQGRl
Ymlhbi5vcmcACgkQYmRes19oaooQ1hAApWTFwBWb8qw3IKiORu73SfCJqBmwPfNf
0DFoG1Bv38z0zRY5iUmzIe93dkfFK3Gln+GRzhHCztl3rT0D8StgMGwjq/XX8snf
fzRtZdfMVxhyrSIQ3aKmMrwv1J/szzP2mwosd5qB6+AWspHUC5dUSbXPLH8HCVse
S9NzpEh0Un8xJQCJ5XQxomAIMux9ZL/P1QZMGUS1I+LI7j0TKxPIRNY5YqESOqDt
1p3cawaWkM0a0FG2zx/GgG2FsPOimHY0fdDSYdkNOPzR2KLhAOBRlSLJ33fdVBQg
0Lif/e09W3+iEH3+RbCQnXBY2ofcM4LDC0GXx1J/df3JaT7I9WlVNrRs4xMTNOWX
EIZH5mjVrbSvk05sNTWTCWFBYaKWetQkaiM/OfRoweMkrhmVMT8xKND9jKOd0Lrd
8+hQSCftgy3bGGLPHQQ6Kc9Q5OEgMc1TOX/T8vFCtvHKFwc097t5PwRFz8NZlFSR
s4M+lfiQ7j6TGpMffWsQr6NnrWY2OlqwR8jPbZaj6WhGbz7hSkFxcrV1suyMHemz
hfK09fqxxqw/f12GYq5RXsKef9CHLpt4dy3P5b3ofbcVqjhimWFmbUagTDUtLLvi
ES/AtjCZKvAEBGV7XJNJ9F0uHb/Mh1UzvNuBcGbGonLLaRPTbCf+udJnQRP9J8Lr
9UI1275Rv9U=
=gZry
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: