[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#996702: marked as done (fp16: libfp16 fails to build for i386)

Your message dated Sun, 09 Jan 2022 17:48:29 +0000
with message-id <E1n6cIv-0007ht-Jm@fasolo.debian.org>
and subject line Bug#996702: fixed in fp16 0.0~git20200514.4dfe081-3
has caused the Debian Bug report #996702,
regarding fp16: libfp16 fails to build for i386
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
996702: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=996702
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: fp16
Severity: normal
Tags: patch upstream

Dear Maintainer,

the function fp16_ieee_from_fp32_value() fails to pass tests on i386 arch,
resulting in missing packages https://buildd.debian.org/status/package.php?p=fp16

I think the problem here is implicit usage of double type at include/fp16/fp16.h:231.
The patch should fix that.

Index: fp16/include/fp16/fp16.h
===================================================================
--- fp16.orig/include/fp16/fp16.h
+++ fp16/include/fp16/fp16.h
@@ -228,7 +228,8 @@ static inline uint16_t fp16_ieee_from_fp
 	const float scale_to_inf = fp32_from_bits(UINT32_C(0x77800000));
 	const float scale_to_zero = fp32_from_bits(UINT32_C(0x08800000));
 #endif
-	float base = (fabsf(f) * scale_to_inf) * scale_to_zero;
+        const volatile float base_inf = fabsf(f) * scale_to_inf;
+	float base = base_inf * scale_to_zero;
 
 	const uint32_t w = fp32_to_bits(f);
 	const uint32_t shl1_w = w + w;

--- End Message ---
--- Begin Message --- 
Source: fp16
Source-Version: 0.0~git20200514.4dfe081-3
Done: Mo Zhou <lumin@debian.org>

We believe that the bug you reported is fixed in the latest version of
fp16, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 996702@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mo Zhou <lumin@debian.org> (supplier of updated fp16 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 09 Jan 2022 12:20:10 -0500
Source: fp16
Architecture: source
Version: 0.0~git20200514.4dfe081-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Deep Learning Team <debian-ai@lists.debian.org>
Changed-By: Mo Zhou <lumin@debian.org>
Closes: 996702
Changes:
 fp16 (0.0~git20200514.4dfe081-3) unstable; urgency=medium
 .
   * Fix i386 FTBFS with patch. (Closes: #996702)
   * d/copyright: Fix superfluous file pattern (lintian).
Checksums-Sha1:
 41e36831befe861bcd96113644794a40d61f7a98 2114 fp16_0.0~git20200514.4dfe081-3.dsc
 9c4f44675277b7281d64e90e6a283b374bdeccca 10244 fp16_0.0~git20200514.4dfe081-3.debian.tar.xz
 d7a4304ea072ae7c15f9cd00946b7107a8a6ca0e 6434 fp16_0.0~git20200514.4dfe081-3_source.buildinfo
Checksums-Sha256:
 c6febfbbba196b5f67113540a94db9adfc20da5fab0bd3ef9d8d2edd0f35e996 2114 fp16_0.0~git20200514.4dfe081-3.dsc
 6b407565616a167128ef75e945b0aced7d3d1a2fa49a2686d1a07705577db245 10244 fp16_0.0~git20200514.4dfe081-3.debian.tar.xz
 fce4feea25fb74f44f92f3aa1050a92d0f917f17397f62c0c7c964a4260cdd1f 6434 fp16_0.0~git20200514.4dfe081-3_source.buildinfo
Files:
 c0a6653e25f628d9ef01d0f67653f0a3 2114 math optional fp16_0.0~git20200514.4dfe081-3.dsc
 f5f66d733dc95e5f9183e9aab5b5ccc2 10244 math optional fp16_0.0~git20200514.4dfe081-3.debian.tar.xz
 4832de4042861678fc8446c84e2a5006 6434 math optional fp16_0.0~git20200514.4dfe081-3_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCgAvFiEEY4vHXsHlxYkGfjXeYmRes19oaooFAmHbGWoRHGx1bWluQGRl
Ymlhbi5vcmcACgkQYmRes19oaorteQ//Y6k3fWVl22knXlkI7ha1ZJp4Ak4K1Y1C
1R7RbUQMsRbF2QQaXmPDuSG/GKrXZEz4pez1YMdh5qj1yXu0czVt+UmFz8ySvMZb
5/NOUpdHNu4WrHw6OOHx7FacWVFJQD1OrKy3b/CDRm7p4Orl0PCc8jGpwoF3CoSw
4H0Uq3Sy9W0UShLXC/EkGMKCZfS54KHWlAG61kZb3GyfYDeqiT5s0JC2KRTZ4vWj
K89gUz2Pjc4e7fGQPm4rmDSlfkZqvivfgPX0qf028lnBG3eVd3cT4qUzvKgJFBA8
YFazzlJlHVyvq4zWLILh2E6061ZRAhWXDbClf31wUylWdGw5jkN5dm/u7v76UXea
QX1mmlpvpCFksQZRs+F7Z+eGLJRE+3A36I6o07aS+daO8VWC4c95GrWeN8yqHcYZ
CraEoPlsYALJ+UmRJu7vRrUMb7ePVZONOduk5UwdR4D7VM6mC4GWXsfy6mN1qgyx
yJXh65WohsQ74vYGd2w0/mgZlYaLJbU90jhJrKyNBd3iFSMTWhgYGPFlui5xSjXc
g2n/C4l5KQ/FyOBlCvIzFg3dziWg04xVIwY1R40YCUJ+i53O7CVBRUzeK5ordOHR
imldRT1hf2yx2D6w0zgb0XQNpkIPKt1/2qgch+VNjg+UriYaZVLnCXfRO8h5TzOL
/HH7KBW/VT4=
=ZHWT
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: