Re: [PATCH] Add support for GNU/Hurd in gnat-4.9
Am 20.08.2014 um 22:12 schrieb Svante Signell:
> On Wed, 2014-05-21 at 10:48 +0200, Samuel Thibault wrote:
>> Svante Signell, le Wed 21 May 2014 10:44:54 +0200, a écrit :
>>> On Wed, 2014-05-21 at 10:33 +0200, Arnaud Charlet wrote:
>>>>>> I think the majority of work has bee done, Now that patch will change
>>>>>> slightly for every missing feature added to Hurd.
>>>>> Then it's all good, it's a matter of what I said above.
>>>> Don't forget also the part where general changes are done in GNAT which
>>>> require update to target specific files: these typically require someone
>>>> to regularly test each port to detect any missing update, and report/fix
>>>> them, even if GNU/Hurd hasn't changed itself.
>>> With the help from the dabian-ada people, especially Ludovic Brenta,
>>> gnat has been running on GNU/Hurd in Debian since gcc/gnat-4.6.3.
>> Then it's all good. Just say that you wish to continue maintaining
>> things like this, and upstream will be happy.
> Attached is the updated ada-hurd.diff patch for GNU/Hurd. It builds fine
> with gnat-4.9.1-1 and gcc-4.9.1-7. This patch now has the same amount of
> files as the kFreeBSD patch. Hopefully it can be material for upstream,
> but at least in Debian the Hurd port would be on par with kFreeBSD.
> Regarding remaining code commented out or irrelevant comments in the new
> file s-osinte-gnu.ads, please help me to iron out the left-overs.
the patch is at least missing the ChangeLog entry. Also it is only tested using
the Debian package based on the 4.9 branch, and which includes a bunch of local
ada patches which are not forwarded upstream for years. Please prepare and test
your patch with current trunk for upstream submission.
> Ludovic, can you consider using this file as ada-hurd.diff for next
> upload of Debian gnat-4.9?
> For clarity: I wish to continue to maintain the Ada port for Hurd, with
> the help of the Debian Ada and Hurd people, with or without being
> imported upstream.
I disagree. Debian's current local ada patches are a mess, and no effort is made
to cleanup these and forward these upstream. If the Debian Ada people can't do
this, please do it yourself.