Re: Please revert the patches in bug #54040 and #59346 and special case x32
On Tue, 2014-04-08 at 09:26 +0200, Eric Botcazou wrote:
> > Attached is a patch reverting the two commits for PR ada/54040:
> > http://gcc.gnu.org/git/?p=gcc.git&a=search&h=HEAD&st=commit&s=PR+ada%
> > 2F54040
>
> I don't think that's sufficient though, IIRC there were followup changes, so
> you'd better diff the current code with the revision just prior to the change.
The only changes I've found are: (in the previously attached patch)
(the other commits refer to
2014-01-26: lynxos
2014-01-24: android
2014-01-20: linux
2013-01-29 : vms
and they are not related to the patches needing a revert.
(I did make a diff from current to the version before and did not find
anything new). I have also built the reverted version on GNU/Linux
x86-64 out of the box. The only thing needed to change after the revert
might be copyright years.
commit d2a4f256f9bc035ef2d6874c4e4c20c83ebf00b4
Author: ebotcazou <ebotcazou@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Fri Nov 29 16:19:36 2013 +0000
PR ada/54040
PR ada/59346
* s-osinte-hpux.ads (timespec): Change type of tv_nsec field to
time_t.
* s-osinte-kfreebsd-gnu.ads (timespec): Likewise.
* s-osinte-solaris-posix.ads (timespec): Li2014-01-24kewise.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@205532
138bc75d-0d04-0410-961f-82ee72b0
commit e3a1f6b50495473f677f413d8740808a3fde5a9a
Author: hjl <hjl@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Fri Nov 15 12:06:25 2013 +0000
Add and use System.Linux.time_t for time_t
PR ada/54040
* s-linux-x32.ads: New file.
* s-osprim-x32.adb: Likewise.
* s-linux.ads (time_t): New type.
* s-linux-alpha.ads (time_t): Likewise.
* s-linux-hppa.ads (time_t): Likewise.
* s-linux-mipsel.ads (time_t): Likewise.
* s-linux-sparc.ads (time_t): Likewise.
* s-osinte-linux.ads (time_t): Mark it private. Replace long
with System.Linux.time_t.
(timespec): Replace long with time_t.
* s-osinte-posix.adb (To_Timespec): Likewise.
* s-taprop-linux.adb (timeval): Replace C.long with
System.OS_Interface.time_t.
* gcc-interface/Makefile.in (LIBGNAT_TARGET_PAIRS): Replace
s-linux.ads with s-linux-x32.ads, s-osprim-posix.adb with
s-osprim-x32.adb for x32.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@204840
138bc75d-0d04-0410-961f-82ee72b0
Then we have but this one was before adding x32-specific files:
commit 70d595c8e41c9a7fdf5049c5a48c3b50304c8cbe
Author: hjl <hjl@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Sat Mar 3 17:04:49 2012 +0000
Add Linux/x32 support to Ada
2012-03-03 H.J. Lu <hongjiu.lu@intel.com>
* init.c (__gnat_adjust_context_for_raise): Also check
"orq $0x0,(%esp)" for x32.
* link.c (__gnat_default_libgcc_subdir): set to libx32 for x32.
* gcc-interface/Makefile.in (arch): Set to x32 if MULTISUBDIR
is /x32.
Support x32.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@184859
138bc75d-0d04-0410-961f-82ee72b0
Reply to: