[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#875748: qt-at-spi FTCBFS: configures for the build architecture



Source: qt-at-spi
Version: 0.4.0-5
Severity: wishlist
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

qt-at-spi fails to cross build from source, because it configures for
the build architecture. Coming up with the relevant flags for cmake is
tedious, so that task is best deferred to dh_auto_configure. Doing so
makes debian/rules significantly simpler, but doesn't make qt-at-spi
cross build: It still fails with the typical cmake/kde4 failure that
needs to be solved elsewhere.

Still the patch is an incremental improvement and simplifies
debian/rules. Thus I think it is still worth applying. Please close this
bug when you do (or when you pass cross compilers to cmake).

Helmut
diff --minimal -Nru qt-at-spi-0.4.0/debian/changelog qt-at-spi-0.4.0/debian/changelog
--- qt-at-spi-0.4.0/debian/changelog	2016-09-04 18:53:18.000000000 +0200
+++ qt-at-spi-0.4.0/debian/changelog	2017-09-14 10:15:33.000000000 +0200
@@ -1,3 +1,10 @@
+qt-at-spi (0.4.0-5.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Indirect cmake through dh_auto_configure (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Thu, 14 Sep 2017 10:15:33 +0200
+
 qt-at-spi (0.4.0-5) unstable; urgency=medium
 
   * control: Drop hardening-wrapper dependency (Closes: #836650)
diff --minimal -Nru qt-at-spi-0.4.0/debian/rules qt-at-spi-0.4.0/debian/rules
--- qt-at-spi-0.4.0/debian/rules	2016-09-04 17:24:49.000000000 +0200
+++ qt-at-spi-0.4.0/debian/rules	2017-09-14 10:15:29.000000000 +0200
@@ -4,7 +4,6 @@
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all,-bindnow
 
 DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
-DEB_HOST_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
 
 # disable debug and warnings by default, use DEB_BUILD_OPTIONS to enable them
 # back
@@ -18,8 +17,7 @@
 	dh $@ --parallel
 
 override_dh_auto_configure:
-	mkdir obj-$(DEB_HOST_GNU_TYPE)
-	cd obj-$(DEB_HOST_GNU_TYPE) && cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=None -DLIB_SUFFIX=/$(DEB_HOST_MULTIARCH)
+	dh_auto_configure -- -DLIB_SUFFIX=/$(DEB_HOST_MULTIARCH)
 
 override_dh_auto_build:
 	dh_auto_build

Reply to: