Re: Bug#852149: Re : Re: Firefox-ESR Crash in Stretch when exiting Browser with Orca running
Le 01/03/2017 à 23:54, Mike Hommey a écrit :
> Thanks. This points to
> https://bugzilla.mozilla.org/show_bug.cgi?id=1273020
>
> which points to
> https://hg.mozilla.org/integration/mozilla-inbound/rev/8bfdf5dfcf6bcf706fea4cda201f72ffc0c69c4a
>
> Can someone try to apply this patch and see how it goes for them?
Hi,
This patch does not apply cleanly on firefox-esr (45.7.0esr-4).
I attach a corrected patch that does apply cleanly. I am currently
building the package under stretch and will upload it to some public
space when done.
I won't be able to test though, as I can't reproduce the crash.
Regards, Thibaut.
diff --git a/accessible/generic/ApplicationAccessible.h b/accessible/generic/ApplicationAccessible.h
--- a/accessible/generic/ApplicationAccessible.h
+++ b/accessible/generic/ApplicationAccessible.h
@@ -55,39 +55,45 @@ public:
virtual void InvalidateChildren() override;
// ActionAccessible
virtual KeyBinding AccessKey() const override;
// ApplicationAccessible
void AppName(nsAString& aName) const
{
- nsAutoCString cname;
- mAppInfo->GetName(cname);
- AppendUTF8toUTF16(cname, aName);
+ if (mAppInfo) {
+ nsAutoCString cname;
+ mAppInfo->GetName(cname);
+ AppendUTF8toUTF16(cname, aName);
+ }
}
void AppVersion(nsAString& aVersion) const
{
- nsAutoCString cversion;
- mAppInfo->GetVersion(cversion);
- AppendUTF8toUTF16(cversion, aVersion);
+ if (mAppInfo) {
+ nsAutoCString cversion;
+ mAppInfo->GetVersion(cversion);
+ AppendUTF8toUTF16(cversion, aVersion);
+ }
}
void PlatformName(nsAString& aName) const
{
aName.AssignLiteral("Gecko");
}
void PlatformVersion(nsAString& aVersion) const
{
- nsAutoCString cversion;
- mAppInfo->GetPlatformVersion(cversion);
- AppendUTF8toUTF16(cversion, aVersion);
+ if (mAppInfo) {
+ nsAutoCString cversion;
+ mAppInfo->GetPlatformVersion(cversion);
+ AppendUTF8toUTF16(cversion, aVersion);
+ }
}
protected:
virtual ~ApplicationAccessible() {}
// Accessible
virtual void CacheChildren() override;
virtual Accessible* GetSiblingAtOffset(int32_t aOffset,
nsresult *aError = nullptr) const override;
Reply to: