[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#844232: marked as done (daisy-player: man page title is wrong if build directory isn't named ${package}-${version})

Your message dated Sat, 10 Dec 2016 21:04:49 +0000
with message-id <E1cFop7-0007qu-ET@fasolo.debian.org>
and subject line Bug#844232: fixed in daisy-player 10.3-3
has caused the Debian Bug report #844232,
regarding daisy-player: man page title is wrong if build directory isn't named ${package}-${version}
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
844232: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=844232
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: daisy-player
Version: 10.3-2
Severity: minor
Tags: upstream patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath

Dear Maintainer,

Whilst working on the Reproducible Builds effort [0], we noticed
that daisy-player could not be built reproducibly, due to `txt2man -p`
parsing the last component of the build directory.

Patch attached.

 [0] https://reproducible-builds.org/

Cheers,

Daniel

P.S. The patch as written is upstreamable.  For Debian it might make
sense to use «$$(cd .. && dpkg-parsechangelog -SVersion)» so as to have
a more detailed version number.

[[[
diff --git a/debian/patches/build-path-agnostic.diff b/debian/patches/build-path-agnostic.diff
new file mode 100644
index 0000000..94c89c2
--- /dev/null
+++ b/debian/patches/build-path-agnostic.diff
@@ -0,0 +1,16 @@
+Description: Make the build reproducible
+  Avoid 'txt2man -p' because it parses the build path.
+Bug-Debian: https://bugs.debian.org/-1
+Last-Update: 2016-11-13
+
+--- daisy-player-10.3.orig/man/Makefile.am
++++ daisy-player-10.3/man/Makefile.am
+@@ -3,7 +3,7 @@ man_MANS = daisy-player.1
+ all: daisy-player
+ 
+ daisy-player:
+-	@which txt2man > /dev/null && txt2man -p ${srcdir}/../doc/$@.txt > ${srcdir}/$@.1
++	@which txt2man > /dev/null && txt2man -t $@ -s 1 -v "Linux Reference Manual" -r $(VERSION) ${srcdir}/../doc/$@.txt > ${srcdir}/$@.1
+ 	@file ${srcdir}/$@.1 && \
+ 	   man2html ${srcdir}/$@.1 | tail -n +3 > ${srcdir}/../doc/$@.html
+ 
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..222072b
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+build-path-agnostic.diff
]]]

--- End Message ---
--- Begin Message --- 
Source: daisy-player
Source-Version: 10.3-3

We believe that the bug you reported is fixed in the latest version of
daisy-player, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 844232@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Paul Gevers <elbrus@debian.org> (supplier of updated daisy-player package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 10 Dec 2016 20:30:26 +0100
Source: daisy-player
Binary: daisy-player
Architecture: source
Version: 10.3-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Accessibility Team <debian-accessibility@lists.debian.org>
Changed-By: Paul Gevers <elbrus@debian.org>
Description:
 daisy-player - player for DAISY Digital Talking Books
Closes: 844232
Changes:
 daisy-player (10.3-3) unstable; urgency=medium
 .
   * Prevent txt2man -p to pick up the build dir to enable reproducible
     builds. Will be fixed in next upstream release (Closes: #844232)
   * Bump compat level to 10
   * Convert Vcs-* URLs to https
   * Enable hardening
Checksums-Sha1:
 9f629cbc2e77a26d875025908dfa45b5966f112b 1758 daisy-player_10.3-3.dsc
 8bd21bc4ffe996b2a65b8245ab3595b63b954724 8716 daisy-player_10.3-3.debian.tar.xz
Checksums-Sha256:
 d4617786cf8ad44fe24a551f3c0ba2d2d05c4cf73c5f98fcb30c49d5e15ef202 1758 daisy-player_10.3-3.dsc
 3269e1069c11739b24d4ecc9a55ef67ad516dc569053b164ebe8dd1ae9a87e47 8716 daisy-player_10.3-3.debian.tar.xz
Files:
 6654fcb4097d5c95deb6d1279e038057 1758 sound optional daisy-player_10.3-3.dsc
 d8e19f7081549058eea59b354c91d823 8716 sound optional daisy-player_10.3-3.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEWLZtSHNr6TsFLeZynFyZ6wW9dQoFAlhMXSQACgkQnFyZ6wW9
dQpSDwf+Ij6cOCdwQkE8TMO95jLJL4hZi1ANAof7elG7NJhSYeEMRgmTXj2bJcVw
IwEcmUmHU9zj7GH0D4U57Yg4Nkv42hQPtumwEKGCpu4fEWbPyGT0v1CdEd5eupkt
yA7nxS3lf4j/fOfrBIXhpAvjfLaFNbMb/3bDHr6cIWNEw3ybQ2O4yWdH1cdkv8Zq
A5rrSpOndguUJy2JX6PulROSZl2nxVtt4rvx8Wi+8osehWW8pfRCaPJIf4gcXSXu
EZCgavrMO4Xxs1B2G3O4hmm1qJ1gsqaX5YqL9VycbCjx8di8mJm9B+iMjBL7SQG+
ihWiby7jx0eYvNWHBe2qFlZ8yfYQww==
=NMUp
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: