[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#844228: marked as done (ebook-speaker: man page title is wrong if build directory isn't named ${package}-${version})

Your message dated Sat, 10 Dec 2016 19:33:26 +0000
with message-id <E1cFnOg-000AeO-Un@fasolo.debian.org>
and subject line Bug#844228: fixed in ebook-speaker 4.1.0-2
has caused the Debian Bug report #844228,
regarding ebook-speaker: man page title is wrong if build directory isn't named ${package}-${version}
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
844228: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=844228
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: ebook-speaker
Version: 4.1.0-1
Severity: minor
Tags: patch upstream
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath

Dear Maintainer,

Whilst working on the Reproducible Builds effort [0], we noticed
that ebook-speaker could not be built reproducibly, due to `txt2man -p`
parsing the last component of the build directory.

Patch attached.

 [0] https://reproducible-builds.org/

Cheers,

Daniel

P.S. The patch as written is upstreamable.  For Debian it might make
sense to use «$$(cd .. && dpkg-parsechangelog -SVersion)» so as to have
a more detailed version number.


[[[
diff --git a/debian/patches/build-path-agnostic.diff b/debian/patches/build-path-agnostic.diff
new file mode 100644
index 0000000..5d547f3
--- /dev/null
+++ b/debian/patches/build-path-agnostic.diff
@@ -0,0 +1,19 @@
+Description: Make the build reproducible
+  Avoid 'txt2man -p' because it parses the build path.
+Bug-Debian: https://bugs.debian.org/-1
+Last-Update: 2016-11-13
+
+--- a/man/Makefile.am
++++ b/man/Makefile.am
+@@ -3,7 +3,10 @@
+ all: eBook-speaker
+ 
+ eBook-speaker:
+-	@which txt2man > /dev/null && txt2man -p ${srcdir}/../doc/$@.txt > \
++	@which txt2man > /dev/null && txt2man \
++		-t 'eBook-speaker' -s 1 -v "Linux Reference Manual" \
++		-r "ebook-speaker-$(VERSION)" \
++		${srcdir}/../doc/$@.txt > \
+ 	       ${srcdir}/$@.1
+ 	@file ${srcdir}/$@.1 && \
+ 	  man2html ${srcdir}/$@.1 | tail -n +3 > ${srcdir}/../doc/$@.html
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..222072b
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+build-path-agnostic.diff
]]]

--- End Message ---
--- Begin Message --- 
Source: ebook-speaker
Source-Version: 4.1.0-2

We believe that the bug you reported is fixed in the latest version of
ebook-speaker, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 844228@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Paul Gevers <elbrus@debian.org> (supplier of updated ebook-speaker package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 10 Dec 2016 10:09:29 +0100
Source: ebook-speaker
Binary: ebook-speaker
Architecture: source
Version: 4.1.0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Accessibility Team <debian-accessibility@lists.debian.org>
Changed-By: Paul Gevers <elbrus@debian.org>
Description:
 ebook-speaker - eBook reader that reads aloud in a synthetic voice
Closes: 844228
Changes:
 ebook-speaker (4.1.0-2) unstable; urgency=medium
 .
   [ Samuel Thibault ]
   * control: Drop html2text suggestion, it is not used any more.
 .
   [ Paul Gevers ]
   * Prevent txt2man -p to pick up the build dir to enable reproducible
     builds. Will be fixed in next upstream release (Closes: #844228)
   * Fix spelling mistake in man page found by Lintian
   * Bump compat level to 10
Checksums-Sha1:
 e0581a5a2aa1b5e670332d0bafc370cdd1b77492 1732 ebook-speaker_4.1.0-2.dsc
 a26efae7cfc6f102cf8b579649c3270ceaa0b674 10124 ebook-speaker_4.1.0-2.debian.tar.xz
Checksums-Sha256:
 ed349d764e7657437093545b912a9d1d6070ec289348e576e253170bcccc6867 1732 ebook-speaker_4.1.0-2.dsc
 cd7839585fc4746afedcd6fd90fc4b1df7ecf4b181d502020cb34b019335b313 10124 ebook-speaker_4.1.0-2.debian.tar.xz
Files:
 41923af7c1697f882272ad1b6e519fb5 1732 sound optional ebook-speaker_4.1.0-2.dsc
 938c193300e4d31f1185ff3780e6bdaa 10124 sound optional ebook-speaker_4.1.0-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEWLZtSHNr6TsFLeZynFyZ6wW9dQoFAlhMUroACgkQnFyZ6wW9
dQqJ0ggAseHhhRIfliZs5Z8enemt+wELa1cX1hY0APxU3JPOfE2PpiSVHNuqlsni
xB2LSUIGXlCsr6rwuBUTmcH4arnQdT/RrUvE4p/zafU93b4WjOikIsgP4BJ2ao5v
bealmY5qEFElbOAgz05HcbfCWwfvTYjlW1asxMmK2dWTLdCT+nhiewno+fydR2L/
D6pEe826PVxBa/IKZZYFaYOu8jStkLZkTmjhZpvBGyQH5d3pT5GZ/fdhGnBYTevU
O2q7iaBWtUOljt+/taqv6eazBJyft4Sr/R9Bjt2IgiuvHpjJo0VhSBgOHpw6inpf
ScQXcKZEnBb8Y00yb+kdji4CIQZygQ==
=gwFV
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: