[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#844232: daisy-player: man page title is wrong if build directory isn't named ${package}-${version}



Paul Gevers wrote on Tue, Nov 15, 2016 at 20:31:33 +0100:
> Hi Daniel,
> 
> On 13-11-16 17:22, Daniel Shahaf wrote:
> >Whilst working on the Reproducible Builds effort [0], we noticed
> >that daisy-player could not be built reproducibly, due to `txt2man -p`
> >parsing the last component of the build directory.
> 
> While upstream (thanks Jos) already accepted your patch, I challenge your
> approach. While this CAN be fixed in each package that uses txt2man,
> shouldn't txt2man be fixed instead (I don't see why the parent directory
> should matter for the output)? At least, can you explain why you didn't go
> that route?
> 

I assumed that txt2man's -p (probe) option's incumbent behaviour was
intentional and desirable behaviour in some use-cases.  Granted,
"building Debian packages" is not one of those use-cases, but we can't
change the behaviour of an upstream tool just because package builds
happen to use it.

Perhaps there's a way for txt2man to probe the package name and version
in another way, that works both for Debian package builds and for
upstream txt2man's other usecases.  I'm afraid I injured my hand
yesterday so I can't look into this possibility presently, but I can
look into it once my hand is better.

Thanks for your prompt response the the two bugs!

Cheers,

Daniel

> Paul
> 


Reply to: