[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#726783: marked as done (Add support for systemd)



Your message dated Thu, 13 Mar 2014 10:34:03 +0000
with message-id <E1WO2xf-0007Gc-Cv@franck.debian.org>
and subject line Bug#726783: fixed in brltty 5.0-1
has caused the Debian Bug report #726783,
regarding Add support for systemd
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
726783: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726783
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: brltty
Version: 4.5-3+b1
Severity: normal
Tags: patch
User: pkg-systemd-maintainers@lists.alioth.debian.org
Usertags: systemd-units
X-Debbugs-CC: pkg-systemd-maintainers@lists.alioth.debian.org

BRLTTY includes a systemd service file, which is currently not installed by
the Debian package. Furthermore, the upstream version of this file has
improvements over the version included in the BRLTTY 4.5 source, and
additional changes were necessary for the Debian environment (the path and
command line options of the executable, most notably).

I have included a revised version as debian/brltty.service.

Here is a patch. Review and improvements are most welcome.


>From ca26011b0b4a7eef89e48c5d68f7bbab7f1c54c3 Mon Sep 17 00:00:00 2001
From: Jason White <jason@jasonjgw.net>
Date: Sat, 19 Oct 2013 18:03:31 +1100
Subject: [PATCH] Add systemd service.

---
 debian/brltty.service | 30 ++++++++++++++++++++++++++++++
 debian/changelog      |  8 ++++++--
 debian/control        |  2 +-
 debian/rules          |  3 +++
 4 files changed, 40 insertions(+), 3 deletions(-)
 create mode 100644 debian/brltty.service

diff --git a/debian/brltty.service b/debian/brltty.service
new file mode 100644
index 0000000..a856712
--- /dev/null
+++ b/debian/brltty.service
@@ -0,0 +1,30 @@
+[Unit]
+
+Description=Braille Device Support
+Documentation=man:brltty(1)
+Documentation=http://mielke.cc/brltty/
+
+DefaultDependencies=no
+Before=sysinit.target
+
+
+[Service]
+
+Type=forking
+PIDFile=/run/brltty.pid
+ExecStart=/sbin/brltty -q -P /run/brltty.pid
+
+TimeoutStartSec=5
+TimeoutStopSec=10
+
+Restart=always
+RestartSec=30
+
+Nice=-10
+OOMScoreAdjust=-900
+
+
+[Install]
+WantedBy=sysinit.target
+
+
diff --git a/debian/changelog b/debian/changelog
index c145a5b..8c31e1a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,10 +1,14 @@
 
+  [ Samuel Thibault ]
   * control:
     - Make python*-brlapi description more explict.
     - Bump Standards-Version to 3.9.4 (no changes).
 
- -- Samuel Thibault <sthibault@debian.org>  Sun, 23 Jun 2013 21:07:45 +0200
+  [ Jason White ]
+  * Add support for systemd (based on upstream service file).
+
+ -- Jason White <jason@jasonjgw.net>  Sat, 19 Oct 2013 17:15:54 +1100
 
 brltty (4.5-3) unstable; urgency=low
 
diff --git a/debian/control b/debian/control
index 1401a8b..83e26e3 100644
--- a/debian/control
+++ b/debian/control
@@ -6,7 +6,7 @@ Uploaders: Mario Lang <mlang@debian.org>, Samuel Thibault <sthibault@debian.org>
 Vcs-Browser: http://git.debian.org/?p=pkg-a11y/brltty.git;a=summary
 Vcs-Git: git://git.debian.org/git/pkg-a11y/brltty.git
 Homepage: http://mielke.cc/brltty/
-Build-Depends: debhelper (>= 7), dh-lisp,
+Build-Depends: debhelper (>= 7), dh-lisp, dh-systemd (>= 1.5),
                autotools-dev, autoconf, tcl (>= 8.5~),
                libasound2-dev [linux-any],
                python-all-dev (>= 2.7~0),
diff --git a/debian/rules b/debian/rules
index 953d619..767fbca 100755
--- a/debian/rules
+++ b/debian/rules
@@ -143,8 +143,11 @@ brltty: build-brltty build-python
 	for file in Drivers/Braille/*/README*; \
 		do cp $$file `pwd`/debian/$(PACKAGE)/usr/share/doc/brltty/`basename $$(dirname $$file)`.`basename $$file`; \
 		done
+	dh_systemd_enable -p$@
 	# -r because we don't want to lose the console on an upgrade
 	dh_installinit -p$@ -r -- start 25 S .
+	# and likewise for systemd
+	dh_systemd_start -p$@ --restart-after-upgrade
 	dh_installchangelogs Documents/ChangeLog
 	dh_installman
 	dh_lintian
-- 
1.8.4.rc3

--- End Message ---
--- Begin Message ---
Source: brltty
Source-Version: 5.0-1

We believe that the bug you reported is fixed in the latest version of
brltty, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 726783@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Mario Lang <mlang@debian.org> (supplier of updated brltty package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 13 Mar 2014 11:18:19 +0100
Source: brltty
Binary: brltty brltty-dbg libbrlapi0.6 libbrlapi-dbg libbrlapi-dev libbrlapi-jni libbrlapi-java brltty-flite brltty-speechd brltty-espeak brltty-udeb brltty-x11 xbrlapi cl-brlapi python-brlapi python3-brlapi
Architecture: source amd64 all
Version: 5.0-1
Distribution: unstable
Urgency: low
Maintainer: Debian Accessibility Team <debian-accessibility@lists.debian.org>
Changed-By: Mario Lang <mlang@debian.org>
Description: 
 brltty     - Access software for a blind person using a braille display
 brltty-dbg - debugging symbols for brltty
 brltty-espeak - Access software for a blind person - espeak driver
 brltty-flite - Access software for a blind person - Flite speech driver
 brltty-speechd - Access software for a blind person - Speech Dispatcher driver
 brltty-udeb - Access software for a blind person using a braille display (udeb)
 brltty-x11 - Access software for a blind person using a braille display - X11
 cl-brlapi  - Common Lisp bindings for BrlAPI
 libbrlapi-dbg - braille display access via BRLTTY - shared library debugging symb
 libbrlapi-dev - Library for communication with BRLTTY - static libs and headers
 libbrlapi-java - Java bindings for BrlAPI
 libbrlapi-jni - Java bindings for BrlAPI (native library)
 libbrlapi0.6 - braille display access via BRLTTY - shared library
 python-brlapi - Braille display access via BRLTTY - Python bindings
 python3-brlapi - Braille display access via BRLTTY - Python3 bindings
 xbrlapi    - Access software for a blind person using a braille display - xbrl
Closes: 708585 725986 726783
Changes: 
 brltty (5.0-1) unstable; urgency=low
 .
   [ Samuel Thibault ]
   * control:
     - Make python*-brlapi description more explicit.
     - Bump Standards-Version to 3.9.5 (no changes).
   * debian/initramfs/hooks/brltty: rename to .in, and make DEB_HOST_MULTIARCH
     computed at build time by debian/rules (Closes: #725986).
   * Add brltty 5.0 USB IDs to udev rules.
 .
   [ Jason White ]
   * Add support for systemd (based on upstream service file).
     Closes: #726783.
 .
   [ Paul Gevers ]
   * Adjust build and source files to be able to build against
     speech-dispatcher 0.8
   * Fix timestamp in man pages and strip LinuxDoc-Tools version from html
     (Closes: #708585)
 .
   [ Mario Lang ]
   * New upstream release.
   * debian/source/options: compress with xz.
   * debian/patches/20-sbin.patch: Update.
   * debian/patches/30-format-security.patch: New.
   * debian/brltty.examples: Update to account for renaming of a directory.
   * (temporarily) disable bluetooth in udeb to prevent linking against
     non-udeb packages.
   * debian/patches/60-fix-man-install.patch: Cherry pick
     a1e3a6a71d1278e243881ae7abdf0b65841c6aee from upstream to fix
     installation of man pages for driver-specific tools.
   * debian/patches/70-fs-hang-fix.patch: Cherry pick
     aa3c189d5fb32859d2e93164f59255db35aea4f8 from upstream to fix
     issues with FreedomScientific driver.
Checksums-Sha1: 
 8c01c8bbd46677c330412f5ccf305058f55a9139 2382 brltty_5.0-1.dsc
 73cb04102b96ef1e70bc3bcbc6732288cd04493e 2213768 brltty_5.0.orig.tar.xz
 6f090e6fb161cbb989fe202e0e343c80264778c4 27872 brltty_5.0-1.debian.tar.xz
 f73f15defe1158fbe6965c0228baae83e1b95759 1162004 brltty_5.0-1_amd64.deb
 d53a43243657351748f31072daaf51c85ddeec53 1150744 brltty-dbg_5.0-1_amd64.deb
 add80c55d74b3b6f46d702bfa54ab8cb05d0eb05 79138 libbrlapi0.6_5.0-1_amd64.deb
 0158c3feae23c4b2d5a0e017d886c35df29cf7fb 369574 libbrlapi-dbg_5.0-1_amd64.deb
 7613b0a79ec49b02af7a14f51abd893611a239f3 208894 libbrlapi-dev_5.0-1_amd64.deb
 1f0225b2081f9b05fd98d4080af327503130e565 71408 libbrlapi-jni_5.0-1_amd64.deb
 fd8b19be7752bc6a20b9a743e510638cb88436d1 66362 brltty-flite_5.0-1_amd64.deb
 cf3f3a4a63e1d38c144d7a15117fec4e4702dc7d 66960 brltty-speechd_5.0-1_amd64.deb
 683b5856d3e09f45266a4050dfa9523e631658e7 66338 brltty-espeak_5.0-1_amd64.deb
 45209860aeab69de142e8a7cc1654e8daf2f5fff 80946 brltty-x11_5.0-1_amd64.deb
 e24c96e67f08f1c453b5c9cb7de4140dd30e92b3 103664 xbrlapi_5.0-1_amd64.deb
 83575afc720350853e94afe9e6c75eed6428011e 107822 python-brlapi_5.0-1_amd64.deb
 820a4521e528e8c232a8bd04f44ed616bbe3a7d3 116686 python3-brlapi_5.0-1_amd64.deb
 8319a82f5b37b6f51435fb88a015a7f05b317967 119164 libbrlapi-java_5.0-1_all.deb
 25b50e5ee6051a3546c0ad743fd674b89bc050e9 66508 cl-brlapi_5.0-1_all.deb
 cd311a03c07379ac4b039d6070976fe3211f435c 268214 brltty-udeb_5.0-1_amd64.udeb
Checksums-Sha256: 
 2de40b395167fc82f164087635ed46cb3b0a84dfad468ab9af38e2d0731b449b 2382 brltty_5.0-1.dsc
 e3613fa2e8c3450d7e7bee7107235344c474dc310af5adcc19761f361e8c8b92 2213768 brltty_5.0.orig.tar.xz
 9b8fc400286aa15784f8fd0e7d2566ee214b5758b59a735d2cf8d85697ba9797 27872 brltty_5.0-1.debian.tar.xz
 f79cb822e8024610a5c93762e76e0b1ca5475b3aabdbf90980e6fbbc6e255e9f 1162004 brltty_5.0-1_amd64.deb
 5d3ba26c3b36252036cabda80123261c593008fc420a48c3beffef98102b99ce 1150744 brltty-dbg_5.0-1_amd64.deb
 d2f67ae3e00ca6e89c93a358e805575871682de0beb9efa9f8911927f914425a 79138 libbrlapi0.6_5.0-1_amd64.deb
 0fb086844dfa88434643bb2f42d3f4da5fd42439d54938076279b33d7b391008 369574 libbrlapi-dbg_5.0-1_amd64.deb
 b878896669e0a40e08fddd4740db953c5b660e53f86318ca8ebc44cd2c40e379 208894 libbrlapi-dev_5.0-1_amd64.deb
 05caf78f42f6df0778a1848a0292c950f23e216e621d0f88514ab4b18ec1b2da 71408 libbrlapi-jni_5.0-1_amd64.deb
 bc69a4a34aa519dd8d43e1fb33b9bd03daa71cbaf5e037c80d618486dd233388 66362 brltty-flite_5.0-1_amd64.deb
 bfb787dd55e4b7c3b080c0b7b47c8de9f57e90a876fd717b17d4b0339587d2ad 66960 brltty-speechd_5.0-1_amd64.deb
 9eaf2a4ad9e3429c0305afe745d3f37aac8889c937d0360c579f64a9dff4688b 66338 brltty-espeak_5.0-1_amd64.deb
 8fd9b4f80e8f3a31ffc955906eb60bdbe7b12cb717139be331d724f0fb95aa92 80946 brltty-x11_5.0-1_amd64.deb
 51739be5ff07bd2d4f33a1ba79d5680c1e3db03b6513fdf134480694598f7931 103664 xbrlapi_5.0-1_amd64.deb
 08b14195d2b7c1dda07916eb0815ba68e696e080d1cdfb4d12b753db7ee8a63d 107822 python-brlapi_5.0-1_amd64.deb
 6c46f499f1ae3533f02e41b9362ee082968790ca712c5aee9f4ecba861dc5e2b 116686 python3-brlapi_5.0-1_amd64.deb
 0db346c95ca2b494e7747bb68f5ac20bc083105cff27af80a02a965923bde043 119164 libbrlapi-java_5.0-1_all.deb
 f3e93331d793bafc15cba724cdc2014fa9da5667c2ff1db77fd42fda339867ec 66508 cl-brlapi_5.0-1_all.deb
 64c37bce1d02f403f3992493f410bff469b303b707ba2672eb12b15bd6dea1e2 268214 brltty-udeb_5.0-1_amd64.udeb
Files: 
 048336eddb6bc109bcc2b8037ce40967 2382 admin extra brltty_5.0-1.dsc
 44c71a973424658557b931f703017481 2213768 admin extra brltty_5.0.orig.tar.xz
 806f174248bef046de2f98edfead2532 27872 admin extra brltty_5.0-1.debian.tar.xz
 b7cbc87321404fd4346411baa2de545a 1162004 admin extra brltty_5.0-1_amd64.deb
 78aee00e56f0bccd45668a75f5f31910 1150744 debug extra brltty-dbg_5.0-1_amd64.deb
 9fc37018b8d6d68d83d92fa0de38bda0 79138 libs extra libbrlapi0.6_5.0-1_amd64.deb
 f91de8c047e18ed415a2a510fbe90a88 369574 debug extra libbrlapi-dbg_5.0-1_amd64.deb
 e9977118868a9811b40c5a390db32784 208894 libdevel extra libbrlapi-dev_5.0-1_amd64.deb
 37ec3e0b545cc8f5ba476359972655b0 71408 java extra libbrlapi-jni_5.0-1_amd64.deb
 5c4adb02e39f369bb96959de0560ec17 66362 admin extra brltty-flite_5.0-1_amd64.deb
 aceb9385bf0afcc779dfec20420d93a3 66960 admin extra brltty-speechd_5.0-1_amd64.deb
 12831d82218eb33bf4184de9592a9a42 66338 admin extra brltty-espeak_5.0-1_amd64.deb
 eaa2cff82bbd29d4f304041d0719ae1e 80946 admin extra brltty-x11_5.0-1_amd64.deb
 c988061e52912058349b0fbae10761ac 103664 admin extra xbrlapi_5.0-1_amd64.deb
 93d4ea5b8c292fc6c0ade42683ee6864 107822 python extra python-brlapi_5.0-1_amd64.deb
 965c63281237a20ba37bc05b169c58dd 116686 python extra python3-brlapi_5.0-1_amd64.deb
 fc7d51e4c593539e7b2ca312553595a1 119164 java extra libbrlapi-java_5.0-1_all.deb
 bdfa92af76d72896d42720b40d62dbf8 66508 lisp extra cl-brlapi_5.0-1_all.deb
 3531b030d741792d3fd63c330ab50f2c 268214 debian-installer extra brltty-udeb_5.0-1_amd64.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iD8DBQFTIYcH3/wCKmsRPkQRAgAuAJwMb3fl2TdnqlkhUv/osJO1pRzwXQCZAWMo
iTEdbqewsFNzCISYp9zLeAk=
=Taf7
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: