[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#734273: marked as done (sphinxtrain: FTBFS on big endian: Bad use of SWAP_LE_32())



Your message dated Sun, 05 Jan 2014 16:49:07 +0000
with message-id <E1Vzqst-00036a-Qn@franck.debian.org>
and subject line Bug#734273: fixed in sphinxtrain 1.0.8-2
has caused the Debian Bug report #734273,
regarding sphinxtrain: FTBFS on big endian: Bad use of SWAP_LE_32()
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
734273: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=734273
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: sphinxtrain
Version: 1.0.8-1
Severity: important
Tags: patch
User: debian-powerpcspe@breakpoint.cc
Usertags: powerpcspe

Hi,

on big endian architectures (powerpc, powerpcspe, ppc64, s390x, sparc),
sphinxtrain FTBFS like this:

...
Making all in mk_s2sendump
make[4]: Entering directory `/«PKGBUILDDIR»/src/programs/mk_s2sendump'
gcc -DPACKAGE_NAME=\"SphinxTrain\" -DPACKAGE_TARNAME=\"sphinxtrain\" -DPACKAGE_VERSION=\"1.0.8\" -DPACKAGE_STRING=\"SphinxTrain\ 1.0.8\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DWORDS_BIGENDIAN=1 -DHAVE_LIBM=1 -I. -I../../../include  -I/usr/include/powerpc-linux-gnuspe -I/usr/include/powerpc-linux-gnuspe/sphinxbase    -g -O2 -c mk_s2sendump.c
mk_s2sendump.c: In function 'fwrite_int32':
mk_s2sendump.c:85:5: error: invalid type argument of unary '*' (have 'int32')
mk_s2sendump.c:85:5: error: invalid type argument of unary '*' (have 'int32')
mk_s2sendump.c:85:5: error: invalid type argument of unary '*' (have 'int32')
mk_s2sendump.c:85:5: error: invalid type argument of unary '*' (have 'int32')
mk_s2sendump.c:85:5: error: invalid type argument of unary '*' (have 'int32')
make[4]: *** [mk_s2sendump.o] Error 1
make[4]: Leaving directory `/«PKGBUILDDIR»/src/programs/mk_s2sendump'
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory `/«PKGBUILDDIR»/src/programs'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/«PKGBUILDDIR»/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/«PKGBUILDDIR»'
dh_auto_build: make -j1 returned exit code 2
make: *** [build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch gave error exit status 2
...

This is due to wrong (probably untested) use of SWAP_LE_32() conditionally
defined to be returning identity on little endian. However, on big endian
arches, it requires the pointer to the object, not the object itself. The
attached patch fixes this.

Roland

-- System Information:
Debian Release: 7.0
  APT prefers unreleased
  APT policy: (500, 'unreleased'), (500, 'unstable')
Architecture: powerpcspe (ppc)

Kernel: Linux 3.9.0-dirty (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/dash
Index: sphinxtrain-1.0.8/src/programs/mk_s2sendump/mk_s2sendump.c
===================================================================
--- sphinxtrain-1.0.8.orig/src/programs/mk_s2sendump/mk_s2sendump.c	2014-01-05 14:25:43.000000000 +0100
+++ sphinxtrain-1.0.8/src/programs/mk_s2sendump/mk_s2sendump.c	2014-01-05 14:25:43.000000000 +0100
@@ -82,7 +82,7 @@
 
 static void fwrite_int32 (FILE *fp, int32 val)
 {
-    SWAP_LE_32(val);
+    SWAP_LE_32(&val);
     fwrite (&val, sizeof(int), 1, fp);
 }
 

--- End Message ---
--- Begin Message ---
Source: sphinxtrain
Source-Version: 1.0.8-2

We believe that the bug you reported is fixed in the latest version of
sphinxtrain, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 734273@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Samuel Thibault <sthibault@debian.org> (supplier of updated sphinxtrain package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 05 Jan 2014 17:07:57 +0100
Source: sphinxtrain
Binary: sphinxtrain
Architecture: source amd64
Version: 1.0.8-2
Distribution: unstable
Urgency: low
Maintainer: Debian Accessibility Team <debian-accessibility@lists.debian.org>
Changed-By: Samuel Thibault <sthibault@debian.org>
Description: 
 sphinxtrain - Speech recognition tool - training tool
Closes: 734273
Changes: 
 sphinxtrain (1.0.8-2) unstable; urgency=low
 .
   [ Samuel Thibault ]
   * Bump Standards-Version to 3.9.5 (no changes).
   * control: build-depend on python-support.
 .
   [ Roland Stigge ]
   * patches/fix-powerpcspe.patch: New patch to fix FTBFS on big-endian archs
     (Closes: #734273).
Checksums-Sha1: 
 b524d61457f8823ef10f81f9b3c7a1aad8228a46 1995 sphinxtrain_1.0.8-2.dsc
 5204f8b4df7392025ae14911616826e940b152fb 4060 sphinxtrain_1.0.8-2.debian.tar.gz
 53b4ea06487c4db22e798728594fdd04a2bf4fca 1926514 sphinxtrain_1.0.8-2_amd64.deb
Checksums-Sha256: 
 24a860bd308f8ed6e77149f624c4f5ff0dbafce7d8d16bf2327ef8dbf3cdfd42 1995 sphinxtrain_1.0.8-2.dsc
 7ff970275656782c5ce420bec0e1bfd406798b6ae8212159435c553634edda22 4060 sphinxtrain_1.0.8-2.debian.tar.gz
 d389fbb646dc859d0c4caa1f5954238012120c5a7b6b9c9cc608962bdbdce469 1926514 sphinxtrain_1.0.8-2_amd64.deb
Files: 
 40604e54e998189ef4a23d33983d6a15 1995 sound extra sphinxtrain_1.0.8-2.dsc
 369213d8c684e9d7ce1b51bc14c31bbf 4060 sound extra sphinxtrain_1.0.8-2.debian.tar.gz
 f8e6c0017df041d1cbc30aee60499e22 1926514 sound extra sphinxtrain_1.0.8-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iQIcBAEBCgAGBQJSyYeBAAoJEJTQtYw0gxjVetEP/3RqgDWKqD8O6lxptZzSS6tf
XVZVDCVbTafR6jtdcqcAvIHYnGlG+5CMdSUr/AsYDvaNjtWkysRenfSxWQv7mfj8
g3RVNCLPFIJSDANydESv2nto/oStbPFaq96zzT6MqnVeALyQCYvKH4hReXVO3K0+
usSKg5393gt/XhAK+ynZ6+G5HkirLDrQl8nf9guLqnxcy8o99l1Zj525O/lLdKQY
5abOsGN69dXZ1XDO2rLxJK232LGZ0N/2FwOkhcV34Rp89UkRdq47f0sgDwR8vVJ6
qF4Via4/b2XHHJnrhf0n4rBBUIiYl1MofjuugPmKfPSfT7F7LxJrZd5k8wTZFhGj
/7/KTiqEYCFvPRdl7aQ5OGG8rfYey5Z7t3sKk2XFhVyUHmBD3bY5e+E/1mDCeZB0
h2DGGh8MXarV0ujvP8O8rAOnfo70DqWFFjIh+B/STKAyEiksdwiAu0U917IQUq26
0xPKmr6EXRpjgNZ0K6IhLbG8P19oHen9Xnx89G43NwlNqGcdlbigLqRhpqfW0LZp
p33lYzmsdhAFsLHFj4R0zxHefOxZo/dY6zt4ETTHZVEXv+MPizTTXGB3bLPWrhpY
DIy8ZhN+ypAID7vqNoLeX8Yh6P7yABDjwCxZjqfBKhYC2snMFwuxVKsjd0j/5TSo
QRln6uC3ts+gQQ3cXflx
=OQtP
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: