[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#707925: marked as done (espeak: Makefile overrides compiler flags from the environment)

Your message dated Wed, 19 Jun 2013 19:18:08 +0000
with message-id <E1UpNtQ-0000k5-Gy@franck.debian.org>
and subject line Bug#707925: fixed in espeak 1.47.11-1
has caused the Debian Bug report #707925,
regarding espeak: Makefile overrides compiler flags from the environment
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
707925: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=707925
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: espeak
Version: 1.47.07-1
Severity: normal

This is the latest Espeak package from the Git repository (not yet uploaded).

The makefile overrides CXXFLAGS, hence the flags supplied by debian/rules are
never applied. In particular, debug symbols are not generated.

Here's a proposed patch.


>From cf92768d5d2a46dd3f253eacd82e577fcec9753d Mon Sep 17 00:00:00 2001
From: Jason White <jason@jasonjgw.net>
Date: Sun, 12 May 2013 18:10:40 +1000
Subject: [PATCH] Don't override compiler flags from the environment in
 Makefile.

---
 debian/patches/compiler-flags | 13 +++++++++++++
 debian/patches/series         |  1 +
 2 files changed, 14 insertions(+)
 create mode 100644 debian/patches/compiler-flags

diff --git a/debian/patches/compiler-flags b/debian/patches/compiler-flags
new file mode 100644
index 0000000..efe1add
--- /dev/null
+++ b/debian/patches/compiler-flags
@@ -0,0 +1,13 @@
+Index: espeak/src/Makefile
+===================================================================
+--- espeak.orig/src/Makefile	2013-05-12 17:08:13.919581196 +1000
++++ espeak/src/Makefile	2013-05-12 17:13:29.755725063 +1000
+@@ -93,7 +93,7 @@
+ OBJS3=$(patsubst %.cpp,%.o,$(SRCS3))
+ LIBS3=-lstdc++ -L . -lespeak
+ 
+-CXXFLAGS=-O2
++CXXFLAGS?=-O2
+ 
+ 
+ all: $(BIN_NAME) $(LIB_NAME) $(STATIC_LIB_NAME) $(BIN2_NAME)
diff --git a/debian/patches/series b/debian/patches/series
index 9c398d1..60983b0 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1 +1,2 @@
+compiler-flags
 sonic
-- 
1.8.1.3

--- End Message ---
--- Begin Message --- 
Source: espeak
Source-Version: 1.47.11-1

We believe that the bug you reported is fixed in the latest version of
espeak, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 707925@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Samuel Thibault <sthibault@debian.org> (supplier of updated espeak package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 19 Jun 2013 20:57:44 +0200
Source: espeak
Binary: espeak espeak-data espeak-data-udeb libespeak1 libespeak-dev espeak-dbg
Architecture: source amd64
Version: 1.47.11-1
Distribution: unstable
Urgency: low
Maintainer: Debian Accessibility Team <debian-accessibility@lists.debian.org>
Changed-By: Samuel Thibault <sthibault@debian.org>
Description: 
 espeak     - Multi-lingual software speech synthesizer
 espeak-data - Multi-lingual software speech synthesizer: speech data files
 espeak-data-udeb - Multi-lingual software speech synthesizer: data for d-i (udeb)
 espeak-dbg - Multi-lingual software speech synthesizer: debugging symbols
 libespeak-dev - Multi-lingual software speech synthesizer: development files
 libespeak1 - Multi-lingual software speech synthesizer: shared library
Closes: 707912 707925
Changes: 
 espeak (1.47.11-1) unstable; urgency=low
 .
   * New upstream release
   * debian/rules: Use phondata-manifest in the espeak-data directory
   * Updated espeak manpage
   * Updated copyright
 .
   [ Jason White ]
   * Pass compiler flags on make command line so they won't be ignored.
     (Closes: #707925)
   * Rebuild object files with AUDIO=runtime after building static library
     without it. (Closes: #707912)
 .
   [ Samuel Thibault ]
   * Add utf-8-init patch to fix initialization of utf-8 locale for proper
     character properties detection.
   * Add pulse-trigger-on-final-chunk patch to flush the pulse output.
Checksums-Sha1: 
 25db316aae284e7eb1d2609a4b3c7231b74b02af 2249 espeak_1.47.11-1.dsc
 e04dd567c2211ad11202a2124b21f45983b58646 2649249 espeak_1.47.11.orig.tar.gz
 1c0a8e27ef5008b0577fd8023c6a217c58aa5203 9272 espeak_1.47.11-1.debian.tar.gz
 a54ebf7682ba9f278aa8294708c2bca1c432e55a 78732 espeak_1.47.11-1_amd64.deb
 fea0bfcc847b9a1a43497ef0729effcb278389f5 998140 espeak-data_1.47.11-1_amd64.deb
 7915629d814af4919043e17f4178d5f3ed53ab34 836310 espeak-data-udeb_1.47.11-1_amd64.udeb
 be9c0e765cdb08a76d9a59b7b8a9fb2c47cc8e8b 166470 libespeak1_1.47.11-1_amd64.deb
 cbfa84212fd75b1289382e21de0322785edadee9 222230 libespeak-dev_1.47.11-1_amd64.deb
 bcdac98ec18eb6f9cdc451a1b3bf89a31ee7fc78 355026 espeak-dbg_1.47.11-1_amd64.deb
Checksums-Sha256: 
 04ac9aec7d3f6f89871066cc56569ca38623da3b67bb6ab789552019c288b619 2249 espeak_1.47.11-1.dsc
 264c766b80bf784cf6956dd6e390a1ee46a1d045a56efabeb65fb9c6556ca173 2649249 espeak_1.47.11.orig.tar.gz
 7c2a1142acd0b3bd57d95b822765158d1cda1a4dd37e35cba10c8b535adc79d6 9272 espeak_1.47.11-1.debian.tar.gz
 a1b56fd235d753007a4c2f926761670b063654c4ae52bb36d4b45726e32d9931 78732 espeak_1.47.11-1_amd64.deb
 f97eb695511bf8e30df61bb4d865612897c755dbdcaf1c46b3a8b12a4b71225b 998140 espeak-data_1.47.11-1_amd64.deb
 81af729f81c9caaeb9a65b2ce12bb82c46e01f6d4c7c77f246adc4af1a99d1a2 836310 espeak-data-udeb_1.47.11-1_amd64.udeb
 5068786648483ffee1779d8855567db023719ef4781862d872e8da98b62081ff 166470 libespeak1_1.47.11-1_amd64.deb
 70b24423ed3389cbd60f6f1556dfa4317718ed61eeecb18c07ca30f2602038ad 222230 libespeak-dev_1.47.11-1_amd64.deb
 4522edd57242f87a698adf6dd709e0b233e33c47bbc3837ab6cabe7955aa0677 355026 espeak-dbg_1.47.11-1_amd64.deb
Files: 
 5128818b930246820ffa62bb29e7500b 2249 sound optional espeak_1.47.11-1.dsc
 49fab32d3a25b29b4462715d4dfacad2 2649249 sound optional espeak_1.47.11.orig.tar.gz
 f6e431a87364d46b9c7179bfc6e362c4 9272 sound optional espeak_1.47.11-1.debian.tar.gz
 8ea4154aa99a7a65f07cd5bfd01f814a 78732 sound optional espeak_1.47.11-1_amd64.deb
 6a078983e43f602cba2d636c8faeceb8 998140 sound optional espeak-data_1.47.11-1_amd64.deb
 151cee7db1458300f561c3ec2d0b6d0f 836310 debian-installer optional espeak-data-udeb_1.47.11-1_amd64.udeb
 89cfd00ce633fd9ba960a31bd2b16823 166470 libs optional libespeak1_1.47.11-1_amd64.deb
 08c66103ca7f62263072069d3f9b7aad 222230 libdevel optional libespeak-dev_1.47.11-1_amd64.deb
 3a4b318f90793b7b32701623b8895bc6 355026 debug extra espeak-dbg_1.47.11-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCgAGBQJRwgCSAAoJECqpogBB8bdX5McP/3aOVBy8pepPlSK++dUKKW5c
1uvT165e38mTD2iFosyCe7BZmPeb8317KV1Q2wXobjb6kOePXYxU+Ya2D/JRlQ3f
SARHcRtl3BYImBu8QjLjVAAQXAEGDsaNHOQr1A+Oy1SUbVKRhp3RwP3ns9tQPOml
tv6AgPzixPVqe/wkq0f7SKNPxRmHGPm+5vUCeEiDRlnXJPIFox8ttWaWcY9YrUIJ
3Dwl3BQE2vi8bl/7nS9U6l9UGhRa/1a5JfUt9FlvoPDCo5iknoCzMuKon6U3fF3z
LFeiCmYqZahswJllEVBvWwaunb9G7CSPoRtpOxQDpC7x0Loa6EswRamqqz65Ke4A
EAlDruzRZmu3WpIqeqHOqAzv7BZBqAPnohkjslN1GlUUsOuYYT6ihmeT870BNUR7
F+l6/SA0/brBGCeAV/YZ4qNek82vWFaEBYlH1XD8qTDHLgdh8HDsung9t3aMJ2NM
+48k7gExiCjKjLFY8VB5Tj4dhJj3pHgEgemhBxTDyQPjsb+NWzK8l6tfJkPfo+qF
0gfTGWXjlkwjbkM1zPLiRLe2FhpTTGXmPAJE62tIOf5O7DMVpajVfTYHSszT166V
YYAw4Sgi5+ql9Aip9QULBk1ystIJze6B+UYTGBTm5RZyPxc9mbUsEMefx1OItdwT
EpNaS+AXFoN1J8bFqakq
=86v+
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: