[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#688127: brltty: Ensure backwards compatible Java bytecode is built



Package: brltty
Version: 4.4-5
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu quantal ubuntu-patch openjdk-7-transition

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * Ensure Java bytecode built is compatible with older versions of Java
    (LP: #1049757):
    - d/p/41-bytecode-compat.patch: Patch to specify source/target = 1.5
      during build process.

By default, the java compiler generates bytecode which is compatible with
itself and upwards; in Ubuntu the default JDK has now switched to openjdk-7
so brltty builds bytecode which is not compatible with openjdk-6 (still in
the archive and usable).

Thanks for considering the patch.


- -- System Information:
Debian Release: wheezy/sid
  APT prefers quantal-updates
  APT policy: (500, 'quantal-updates'), (500, 'quantal-security'), (500, 'quantal')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.5.0-15-generic (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJQWev6AAoJEL/srsug59jDhb8P/2cVjfKh3bwrcLE5vMSWntNO
LBIz1VSctcwTpUyGEUAWSLsa+zF36UErkcpik6h/aGut+ebvm+8G8YKStRJtZCrE
4LM/sUPhg2cHt4R548luhpJ5gXE8CYWwYh5BiZR34FGPyMIeBLIW5VqcX1qNqj1i
rPfHrlHk6g8XhgEvuGveKCNdWoLbTx2yc5e2byWxZ9JZ2OEagXX3/TG43d4y7s8N
F88tMVqA5H5Wz4ebHiAS5jwgw+PJAINNrY+p5Nm7O2uBm/4KZ7V3VFjxSQh3970x
/4tYgtx/EAe9xqtBlVxwRWfZiDkUPnnQoaxpl8FS3Mdub69kqlMsIFX1b4QdI8IQ
pQnfgTTHMJdi9I76zHxbdQSZDgWv6yDqEc8GquadmMAIbk1hb1tN3oHMjeupKwAm
Xmmvvgc+vgWbeR7hDKwZDAvW7vo9rYvNDkgjP+5tJtoeAu5PjMnI8xo+gfxm88uE
FxGgievE7aPF2/OhFdU1SSBwoiUyx1xwGQwbj7z9g/64j1rvmLHQHjtQ1IOnKo6m
J7SiWDI2MlY2so8aXwyF5UoR9AmVYaXLIOKzfRfuRoW1gzu6WfEy0QPcH3bubegt
a1fFPqC9MXJ9cPaBSm8y/y8XoHRALGPRI77DYXXlLhAjyNdyWrQMT1KXEedjvA82
sLKlYxT2ez1yO8EAbstA
=HK3F
-----END PGP SIGNATURE-----
diff -Nru brltty-4.4/debian/patches/41-bytecode-compat.patch brltty-4.4/debian/patches/41-bytecode-compat.patch
--- brltty-4.4/debian/patches/41-bytecode-compat.patch	1970-01-01 01:00:00.000000000 +0100
+++ brltty-4.4/debian/patches/41-bytecode-compat.patch	2012-09-19 16:30:35.000000000 +0100
@@ -0,0 +1,23 @@
+Description: Debian and Ubuntu contain multiple JRE implementations
+ with a minimum compatiblity level of Java 1.5.
+ .
+ This patch ensures that the Java bytecode built by this package is
+ compatible with all versions of Java from 1.5.
+Author: James Page <james.page@ubuntu.com>
+Forwarded: no
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/brltty/+bug/1049757
+
+--- a/Bindings/Java/bindings.m4
++++ b/Bindings/Java/bindings.m4
+@@ -36,9 +36,10 @@ then
+    JAVA_OK=true
+ 
+    JAVA_ENCODING="UTF-8"
++   JAVA_TARGET="-source 1.5 -target 1.5"
+    case "${JAVAC_NAME}"
+    in
+-      javac) JAVAC_OPTIONS="-encoding ${JAVA_ENCODING}";;
++      javac) JAVAC_OPTIONS="-encoding ${JAVA_ENCODING} ${JAVA_TARGET}";;
+       gcj)   JAVAC_OPTIONS="-C --encoding=${JAVA_ENCODING}";;
+       *)     JAVAC_OPTIONS="";;
+    esac
diff -Nru brltty-4.4/debian/patches/series brltty-4.4/debian/patches/series
--- brltty-4.4/debian/patches/series	2012-09-10 05:22:28.000000000 +0100
+++ brltty-4.4/debian/patches/series	2012-09-19 16:24:00.000000000 +0100
@@ -11,3 +11,4 @@
 30-late-fixes-r6625.patch
 40-no-update-pot.patch
 40-cython.patch
+41-bytecode-compat.patch

Reply to: