[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#658667: marked as done (Crashes DECTALK by sending high-bit characters)

Your message dated Fri, 08 Jun 2012 22:11:01 +0000
with message-id <E1Sd7OX-0005Oy-Qg@franck.debian.org>
and subject line Bug#658667: fixed in yasr 0.6.9-3
has caused the Debian Bug report #658667,
regarding Crashes DECTALK by sending high-bit characters
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
658667: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=658667
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: yasr
version: 0.6.9-2
Severity: normal

Yasr allows "extended" characters (with the high bit set) to be sent to a
DECTALK Express. Some of these characters cause the synthesizer to crash,
after which it must be power cycled.

I have implemented a local solution that excludes high-bit characters entirely
(see attached patch). The alternative (and superior) approach would be to use
the existing exclusion mechanism in Yasr by populating the array of
"unspeakable" characters for the DECTALK. This would require each of the
extended characters to be tested to identify those responsible for the
crashes. Since DECTALK Express is English only, as far as I know, there really
isn't much point in sending extended characters to it anyway, so I've locally
adopted the more general solution, which might not be acceptable from a Debian
point of view.

A simple patch is attached.


Index: yasr-0.6.9/yasr/tts.c
===================================================================
--- yasr-0.6.9.orig/yasr/tts.c	2008-02-03 00:10:07.000000000 +1100
+++ yasr-0.6.9/yasr/tts.c	2012-02-05 10:59:06.059007839 +1100
@@ -281,6 +281,9 @@
   char *p = synth[tts.synth].unspeakable;
 
   if (ch < 32) return 1;
+  /* characters with high bit set cause DECTALK to crash */
+  if (tts.synth == TTS_DECTALK && ch & 0x80)
+    return 1;
   while (*p)
   {
     if (*p++ == ch) return 1;

--- End Message ---
--- Begin Message --- 
Source: yasr
Source-Version: 0.6.9-3

We believe that the bug you reported is fixed in the latest version of
yasr, which is due to be installed in the Debian FTP archive:

yasr_0.6.9-3.diff.gz
  to main/y/yasr/yasr_0.6.9-3.diff.gz
yasr_0.6.9-3.dsc
  to main/y/yasr/yasr_0.6.9-3.dsc
yasr_0.6.9-3_amd64.deb
  to main/y/yasr/yasr_0.6.9-3_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 658667@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Samuel Thibault <sthibault@debian.org> (supplier of updated yasr package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 08 Jun 2012 23:31:13 +0200
Source: yasr
Binary: yasr
Architecture: source amd64
Version: 0.6.9-3
Distribution: unstable
Urgency: low
Maintainer: Debian Accessibility Team <debian-accessibility@lists.debian.org>
Changed-By: Samuel Thibault <sthibault@debian.org>
Description: 
 yasr       - General-purpose console screen reader
Closes: 658667 666286
Changes: 
 yasr (0.6.9-3) unstable; urgency=low
 .
   [ Samuel Thibault ]
   * debian/patches/40_dectalk_extended_chars: Avoid sending non-7bit
     characters to dectalk, thanks Jason White for the patch!
     (Closes: Bug#658667).
   * control: Bump Standards-Version to 3.9.3 (no changes).
 .
   [ Cyril Brulebois ]
   * Switch to dh:
     - Bump debhelper build-dep and compat to 8.
     - Use override_dh_*.
     - Use the quilt sequence, fixing applying/unapplying patches, and
       building with build-arch (Closes: #666286).
Checksums-Sha1: 
 4539088156ac09ec78c590367177f4f71a1ef8a5 1318 yasr_0.6.9-3.dsc
 d3f14af790eac5c1dc64933c73148127002de600 3642 yasr_0.6.9-3.diff.gz
 032258e14b2e524a7ac00ba6fc8cfa4ae51e2a3d 64446 yasr_0.6.9-3_amd64.deb
Checksums-Sha256: 
 6f4157f8f155756be1478281f8cdf696e9535e375b777c1ace80cfd37408004f 1318 yasr_0.6.9-3.dsc
 5340d2416fd4290d9443edd2b5c5699eb0e23ba1d7ea823a348916c4c763035e 3642 yasr_0.6.9-3.diff.gz
 9ff321d3a0014a25cd9aeec671360682c82faa9f831fdab85e431abe9b83c54d 64446 yasr_0.6.9-3_amd64.deb
Files: 
 1bef54bdfe46f025e70818b912c68972 1318 admin extra yasr_0.6.9-3.dsc
 abd5be47f98bd8595da2f525488b64e0 3642 admin extra yasr_0.6.9-3.diff.gz
 cb369ed95a305d5324a69398c8205595 64446 admin extra yasr_0.6.9-3_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iF4EAREKAAYFAk/ScQMACgkQUesQhRznqyiTtQD/Wfowy43gJ72711ow7fx3mca/
PtggknTqqjTdhhh1780BANE9rro5M/SzwKMimLHJpfS3NGT4MzdylbPJnAJhdkoY
=anFK
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: