[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#547046: marked as done (espeakup: Incorrect dependencies and runlevels in init.d script?)

Your message dated Sun, 20 Sep 2009 22:30:09 +0000
with message-id <E1MpUv3-0004je-54@ries.debian.org>
and subject line Bug#547046: fixed in speakup 3.1.3-2
has caused the Debian Bug report #547046,
regarding espeakup: Incorrect dependencies and runlevels in init.d script?
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org

547046: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=547046
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package:  espeakup
Version:  3.0.3+git20090303.dfsg.1-1
Severity: serious
Tags:     patch
User:     initscripts-ng-devel@lists.alioth.debian.org
Usertags: incorrect-dependency incorrect-runlevels

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d script.  The script have a hard dependency on the
module-init-tools script, but do not depend on the module-init-tools
package.  This make the package fail to install if the
module-init-tools package isn't installed.  Next, the runlevel list do
not match the update-rc.d call used in the postinst.  I assume the
update-rc.d arguments are correct and the header is wrong.  Finally,
the script depend on files in /usr/, and should depend on $remote_fs.

I discovered the problem by reading
<URL: http://piuparts.debian.org/sid/fail/espeakup_3.1.3-1.log >.

<URL: http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html >
documents the LSB header format.  Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts >.

This patch should fix the issues.  Setting severity serious, as the
script would run to early in the boot and fail to find the files it

diff -urN ../speakup-3.1.3/debian/espeakup.init ../speakup-3.1.3-pere/debian/espeakup.init
--- ../speakup-3.1.3/debian/espeakup.init       2009-09-16 23:04:28.000000000 +0200
+++ ../speakup-3.1.3-pere/debian/espeakup.init  2009-09-16 23:17:29.000000000 +0200
@@ -22,12 +22,10 @@
 # Provides:          espeakup
-# Required-Start:    module-init-tools
-# Required-Stop:
-# Should-Start:
-# Should-Stop:
-# Default-Start:     S
-# Default-Stop:
+# Required-Start:    $remote_fs
+# Required-Stop:     $remote_fs
+# Default-Start:     2 3 4 5
+# Default-Stop:      0 1 6
 # Short-Description: Speakup/espeak connector
 # Description:       Daemon that makes speakup use the espeak
 #                    software speech synthesizer
diff -urN ../speakup-3.1.3/debian/espeakup.postinst ../speakup-3.1.3-pere/debian/espeakup.postinst
--- ../speakup-3.1.3/debian/espeakup.postinst   1970-01-01 01:00:00.000000000 +0100
+++ ../speakup-3.1.3-pere/debian/espeakup.postinst      2009-09-16 23:22:04.000000000 +0200
@@ -0,0 +1,14 @@
+set -e
+# Those using dependency based boot sequencing with sysv-rc and
+# installing espeakup version 3.1.3-1 or earlier would have wrong
+# runlevel symlinks.  Recover from this.
+if [ "$1" = "configure" ] && dpkg --compare-versions "$2" le "3.1.3-1" \
+   && [ -f /etc/rcS.d/S[0-9][0-9]espeakup ] && [ ! -f /etc/rc2.d/S[0-9][0-9]espeakup ]
+    update-rc.d -f espeakup remove

Happy hacking,
Petter Reinholdtsen

--- End Message ---
--- Begin Message ---
Source: speakup
Source-Version: 3.1.3-2

We believe that the bug you reported is fixed in the latest version of
speakup, which is due to be installed in the Debian FTP archive:

  to pool/main/s/speakup/espeakup_3.1.3-2_amd64.deb
  to pool/main/s/speakup/speakup-doc_3.1.3-2_all.deb
  to pool/main/s/speakup/speakup-source_3.1.3-2_all.deb
  to pool/main/s/speakup/speakup-tools_3.1.3-2_all.deb
  to pool/main/s/speakup/speakup_3.1.3-2.diff.gz
  to pool/main/s/speakup/speakup_3.1.3-2.dsc

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 547046@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Samuel Thibault <sthibault@debian.org> (supplier of updated speakup package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.8
Date: Tue, 18 Aug 2009 22:20:22 +0200
Source: speakup
Binary: speakup-source speakup-doc espeakup speakup-tools
Architecture: source all amd64
Version: 3.1.3-2
Distribution: unstable
Urgency: low
Maintainer: Debian Accessibility Team <debian-accessibility@lists.debian.org>
Changed-By: Samuel Thibault <sthibault@debian.org>
 espeakup   - Connector between speakup kernel modules and espeak
 speakup-doc - Documentation for speakup kernel modules
 speakup-source - Source of the speakup kernel modules
 speakup-tools - Tools to manage speakup configuration and synths
Closes: 547046
 speakup (3.1.3-2) unstable; urgency=low
   * debian/speakupconf.1: Fix "restore" command into "load".
   * debian/control: Bump Standards-Version to 3.8.3 (no change needed).
   * debian/espeakup.init (Closes: #547046):
     - move module-init-tools to Should-Start as we do not really depend on it,
       but just need to have speakup modules loaded if they are loaded through
     - add $remote_fs to Required-Start since we need to access /usr files.
   * debian/rules:
     - Set DEB_DH_INSTALLINIT_ARGS to -R to shorten the time during which
       speech is disabled
     - Set DEB_UPDATE_RCD_PARAMS to start 46 S to start espeakup as early as
 38fc4757d28d543d168e96cecadc4ae67d179a39 1317 speakup_3.1.3-2.dsc
 f7853605d1c30f04b3ab5e1f60f276155bd3ec85 7889 speakup_3.1.3-2.diff.gz
 4bba2a12b33fb1eb39f75a525c57b9e6d3986593 59358 speakup-source_3.1.3-2_all.deb
 8e5ff20a6f39b52a40e2be87bf1f867901f9f3a9 33788 speakup-doc_3.1.3-2_all.deb
 fe6c759de471f8ce49ceffdd584e1b698654605e 6980 speakup-tools_3.1.3-2_all.deb
 d466fcc4f30bde2ccde428a3dc4e7c437be88dbb 15480 espeakup_3.1.3-2_amd64.deb
 97f142226281849b91850b2beca3db795a70936610d650d0fad69f42f204dec5 1317 speakup_3.1.3-2.dsc
 2b659d5a1c88b581d87f68a429df3c001013f991169dceb190e81c721c4d86f3 7889 speakup_3.1.3-2.diff.gz
 895e0e7d202197e58c66c09433eb9a9a1b61717eaa968d6b6812af9dc59302bf 59358 speakup-source_3.1.3-2_all.deb
 83b2e3b67f35b307307754877d3e33b459a98f94c7c9d72d0860e16ed1135437 33788 speakup-doc_3.1.3-2_all.deb
 8426f89a5e906fd0a86b23cfa61151b4206ad0065f5962717d15fb9a9f004557 6980 speakup-tools_3.1.3-2_all.deb
 0e02167941e8ec9968fcb14b2a51e49d7d382107afc65198677104f0184340be 15480 espeakup_3.1.3-2_amd64.deb
 a0a6d87dc38406faf4a281b604b894c2 1317 admin extra speakup_3.1.3-2.dsc
 18488c20635c02744fe37bf1e3baaa47 7889 admin extra speakup_3.1.3-2.diff.gz
 5ca0b6907aa98e9c3535824b8dd3eaba 59358 admin extra speakup-source_3.1.3-2_all.deb
 9ac9ad79e86007cdd0ecb4091d2ce9d1 33788 doc extra speakup-doc_3.1.3-2_all.deb
 424623c216af08eb60a8ef2af81f857f 6980 admin extra speakup-tools_3.1.3-2_all.deb
 b6e2b092d9363824ce4e839f5c63453c 15480 admin extra espeakup_3.1.3-2_amd64.deb

Version: GnuPG v1.4.9 (GNU/Linux)


--- End Message ---

Reply to: