[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#530192: marked as done (speakup-tools: bashism in /bin/sh script)

Your message dated Mon, 01 Jun 2009 17:02:04 +0000
with message-id <E1MBAtg-0006Qv-So@ries.debian.org>
and subject line Bug#530192: fixed in speakup 3.0.4.dfsg.1-1
has caused the Debian Bug report #530192,
regarding speakup-tools: bashism in /bin/sh script
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
530192: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=530192
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: speakup-tools
Severity: important
Version: 3.0.3+git20090404.dfsg.1-1
User: debian-release@lists.debian.org
Usertags: goal-dash

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package)
check I've found your package containing a /bin/sh script making use
of a bashism.

checkbashisms' output:
> possible bashism in ./usr/sbin/speakwith line 67 ($UID should be "$(id
> -ru)"):
> test $UID -eq "0" || exit 0
> possible bashism in ./usr/sbin/talkwith line 55 ($UID should be "$(id
> -ru)"):
> test $UID -eq "0" || exit 0
> possible bashism in ./usr/bin/speakupconf line 19 ($UID should be "$(id
> -ru)"):
> if [ $UID -eq "0" ]; then
> possible bashism in ./usr/bin/speakupconf line 34 ($UID should be "$(id
> -ru)"):
>   if [ ! $UID -eq "0" ]; then


Not using bash (or a Debian Policy conformant shell interpreter which doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours.
Please be aware that although bash is currently the default /bin/sh there was
a release goal for Lenny to make dash the default /bin/sh[1], and has been
proposed for squeeze as well[2].

If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html

For more information supporting this goal please refer to Debian Policy,
section 10.4, at:
http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

Hints about how to fix bashisms:
Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
If not already fixed you can read:
https://wiki.ubuntu.com/DashAsBinSh

If you still don't know how to fix the bashisms don't hesitate to reply to
this email, or tag the bug as 'help'.

[1]http://release.debian.org/lenny/goals.txt
[2]http://lists.debian.org/debian-release/2009/04/msg00133.html

Thank you,
Raphael Geissert

--- End Message ---
--- Begin Message --- 
Source: speakup
Source-Version: 3.0.4.dfsg.1-1

We believe that the bug you reported is fixed in the latest version of
speakup, which is due to be installed in the Debian FTP archive:

espeakup_3.0.4.dfsg.1-1_amd64.deb
  to pool/main/s/speakup/espeakup_3.0.4.dfsg.1-1_amd64.deb
speakup-doc_3.0.4.dfsg.1-1_all.deb
  to pool/main/s/speakup/speakup-doc_3.0.4.dfsg.1-1_all.deb
speakup-source_3.0.4.dfsg.1-1_all.deb
  to pool/main/s/speakup/speakup-source_3.0.4.dfsg.1-1_all.deb
speakup-tools_3.0.4.dfsg.1-1_all.deb
  to pool/main/s/speakup/speakup-tools_3.0.4.dfsg.1-1_all.deb
speakup_3.0.4.dfsg.1-1.diff.gz
  to pool/main/s/speakup/speakup_3.0.4.dfsg.1-1.diff.gz
speakup_3.0.4.dfsg.1-1.dsc
  to pool/main/s/speakup/speakup_3.0.4.dfsg.1-1.dsc
speakup_3.0.4.dfsg.1.orig.tar.gz
  to pool/main/s/speakup/speakup_3.0.4.dfsg.1.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 530192@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Samuel Thibault <sthibault@debian.org> (supplier of updated speakup package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 07 May 2009 01:48:36 +0200
Source: speakup
Binary: speakup-source speakup-doc espeakup speakup-tools
Architecture: source all amd64
Version: 3.0.4.dfsg.1-1
Distribution: unstable
Urgency: low
Maintainer: Debian Accessibility Team <debian-accessibility@lists.debian.org>
Changed-By: Samuel Thibault <sthibault@debian.org>
Description: 
 espeakup   - Connector between speakup kernel modules and espeak
 speakup-doc - Documentation for speakup kernel modules
 speakup-source - Source of the speakup kernel modules
 speakup-tools - Tools to manage speakup configuration and synths
Closes: 530192
Changes: 
 speakup (3.0.4.dfsg.1-1) unstable; urgency=low
 .
   * New upstream release.
   * Add a /etc/default/espeakup configuration file.
   * control: Change my email, remove DM-Upload-Allowed.  Add Vcs-Git and
     Vcs-Browser.
   * Patch speakup-tools scripts into getting run under bash
     (Closes: Bug#530192).
Checksums-Sha1: 
 0e3adec89fc1dff8d2b0243fa6be64c5088de4c4 1360 speakup_3.0.4.dfsg.1-1.dsc
 3e485a4695e43e34d66682990ac50a325e92ed8d 127127 speakup_3.0.4.dfsg.1.orig.tar.gz
 ab99af86b114fb6040df66f96a55fed3c3d0637d 7671 speakup_3.0.4.dfsg.1-1.diff.gz
 3521301a1dbc8ed1adfc64f24635fc1e38e269ba 51418 speakup-source_3.0.4.dfsg.1-1_all.deb
 1337ee490715f63a733ea7b3407d226a9d4655ac 29586 speakup-doc_3.0.4.dfsg.1-1_all.deb
 59057fce32376aa792b00919ffdcff0a4f21f48c 7302 speakup-tools_3.0.4.dfsg.1-1_all.deb
 6a34f2111ef04a8fec7e3d0388297ad7e5259cbc 14722 espeakup_3.0.4.dfsg.1-1_amd64.deb
Checksums-Sha256: 
 e7fe32772752b1b91ced6e5cffa431456ec6fe04cc4df0b334354dba81335d72 1360 speakup_3.0.4.dfsg.1-1.dsc
 8ba3e5833ee3639e82ed773a6c803e8d87c036d9e305249b8ae7326228af09d6 127127 speakup_3.0.4.dfsg.1.orig.tar.gz
 9c4f58678950e7273d24a67b87c9f932f7b3ef12b6b711747c6e459c44bbc5ee 7671 speakup_3.0.4.dfsg.1-1.diff.gz
 7ad7f611ad969880a8bb7cd671ea8cf3630cc6e8367cfa0bef57e7a4c9a0afb6 51418 speakup-source_3.0.4.dfsg.1-1_all.deb
 03e108485aeac06b1c773fd15d279cdb28250192447b1458899dfb43618a7956 29586 speakup-doc_3.0.4.dfsg.1-1_all.deb
 a8b318abce587d2364c01021736bfa7c94fa097af577d515e6a631cb2fd6c248 7302 speakup-tools_3.0.4.dfsg.1-1_all.deb
 bb785b605cf30e51e16368e53f23e6e2d2d8c256a65666f2d6a8e171327ba056 14722 espeakup_3.0.4.dfsg.1-1_amd64.deb
Files: 
 847065f41eb73c1dde856935acff0a48 1360 admin extra speakup_3.0.4.dfsg.1-1.dsc
 bb93d1d40ea44bc452dbd233283f53f7 127127 admin extra speakup_3.0.4.dfsg.1.orig.tar.gz
 0a7cc2f4f632deba4b06d281538b3056 7671 admin extra speakup_3.0.4.dfsg.1-1.diff.gz
 896f44609063b93853881f694e24bd98 51418 admin extra speakup-source_3.0.4.dfsg.1-1_all.deb
 8aafde98445026194b696f07b5f4145e 29586 doc extra speakup-doc_3.0.4.dfsg.1-1_all.deb
 0237983a50c6262445b0c4f6a20b3113 7302 admin extra speakup-tools_3.0.4.dfsg.1-1_all.deb
 dde3dd70760adee4c5bc041b3c31d71e 14722 admin extra espeakup_3.0.4.dfsg.1-1_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkokB/YACgkQH3zgowGB3PaOowCgjs3depF0xTRL/WFQerMn2mBo
vRoAoPGBFiaBSIWl6F8IgZbBkNGywtW5
=e5TG
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: