Bug#530192: speakup-tools: bashism in /bin/sh script
Thanks for this observation. Please find a corrected tarball containing
speakwith and talkwith version 0.3, with the indicated corrections.
http://hallenbeck.ftml.net/synthscripts-0.3.tar.bz2
Chuck
On Sat, May 23, 2009 at 02:14:48AM -0500, Raphael Geissert wrote:
> Package: speakup-tools
> Severity: important
> Version: 3.0.3+git20090404.dfsg.1-1
> User: debian-release@lists.debian.org
> Usertags: goal-dash
>
> Hello maintainer,
>
> While performing an archive wide checkbashisms (from the 'devscripts' package)
> check I've found your package containing a /bin/sh script making use
> of a bashism.
>
> checkbashisms' output:
> > possible bashism in ./usr/sbin/speakwith line 67 ($UID should be "$(id
> > -ru)"):
> > test $UID -eq "0" || exit 0
> > possible bashism in ./usr/sbin/talkwith line 55 ($UID should be "$(id
> > -ru)"):
> > test $UID -eq "0" || exit 0
> > possible bashism in ./usr/bin/speakupconf line 19 ($UID should be "$(id
> > -ru)"):
> > if [ $UID -eq "0" ]; then
> > possible bashism in ./usr/bin/speakupconf line 34 ($UID should be "$(id
> > -ru)"):
> > if [ ! $UID -eq "0" ]; then
>
>
> Not using bash (or a Debian Policy conformant shell interpreter which doesn't
> provide such an extra feature) as /bin/sh is likely to lead to errors or
> unexpected behaviours.
> Please be aware that although bash is currently the default /bin/sh there was
> a release goal for Lenny to make dash the default /bin/sh[1], and has been
> proposed for squeeze as well[2].
>
> If you want more information about dash as /bin/sh, you can read:
> http://lists.debian.org/debian-release/2008/01/msg00189.html
>
> For more information supporting this goal please refer to Debian Policy,
> section 10.4, at:
> http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts
>
> Hints about how to fix bashisms:
> Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
> If not already fixed you can read:
> https://wiki.ubuntu.com/DashAsBinSh
>
> If you still don't know how to fix the bashisms don't hesitate to reply to
> this email, or tag the bug as 'help'.
>
> [1]http://release.debian.org/lenny/goals.txt
> [2]http://lists.debian.org/debian-release/2009/04/msg00133.html
>
> Thank you,
> Raphael Geissert
>
>
>
> --
> To UNSUBSCRIBE, email to debian-accessibility-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
--
The Moon is Waning Crescent (2% of Full)
My web site: www.hallenbeck.ftml.net
Microblog: http://identi.ca
--------
If builders built buildings the way programmers wrote programs,
then the first woodpecker that came along would destroy civilization.
Reply to: