Re: BRLTTY finish install script works incorrectly

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Package: brltty
Version: 3.7.2-6
Severity: normal
Tags: patch

Simon Bienlein, le Mon 08 Jan 2007 12:33:12 +0100, wrote:
> I installed the daily built image of January 6 with the following input
> at the boot prompt:
> 
> install brltty=,,de
> 
> With this, I managed that the USB Braille display was identified
> automatically but that the German text table was still used instantly.
> 
> At the reboot, BRLTTY was not started as only the following was enlisted
> in the file /etc/brltty.conf :
> 
> 
> # Created by /usr/lib/finish-install.d/05brltty
> 
> text-table de
> 
> 
> I had expected the missing variables to be filled with default values to
> start BRLTTY.

And I had expected BRLTTY to be happy with just that, which is not
the case.

Mario, I guess brltty-udeb.prebaseconfig should, when $brailleDevice is
empty, output usb:, and when $brailleDriver is empty, put auto? (see
attached patch).

Samuel

--- debian/brltty-udeb.prebaseconfig-orig	2007-01-09 22:53:28.000000000 +0100
+++ debian/brltty-udeb.prebaseconfig	2007-01-09 22:54:23.000000000 +0100
@@ -54,8 +54,10 @@
    if "${found}"
    then
       echo "# Created by ${0}"
-      [ -n "${brailleDriver}" ] && echo "braille-driver ${brailleDriver}"
-      [ -n "${brailleDevice}" ] && echo "braille-device ${brailleDevice}"
+      [ -z "${brailleDriver}" ] && brailleDriver=auto
+      echo "braille-driver ${brailleDriver}"
+      [ -z "${brailleDevice}" ] && brailleDevice=usb:
+      echo "braille-device ${brailleDevice}"
       [ -n "${textTable}" ] && echo "text-table ${textTable}"
    fi
 }