[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#932090: firebird3.0: Please include patch to ensure correct sizes of on-disk structures



John Paul Adrian Glaubitz dixit:

>However, it turns out that my approach is wrong and upstream has already used
>a different approach for firebird4.0 [2], although I haven't tested that on
>m68k yet.

>> [2] https://github.com/FirebirdSQL/firebird/pull/234/commits

(use https://github.com/FirebirdSQL/firebird/pull/234.patch in lynx)

Very much not; firebird3.0 also has that now AFAICT, and now the static
asserts fail.

The alignment assumptions must be made explicit: change something like…

struct foo {
	char a;
	int b;
};

… to:

struct foo {
	char a;
	char padding1[3];
	int b;
};

bye,
//mirabilos
-- 
When he found out that the m68k port was in a pretty bad shape, he did
not, like many before him, shrug and move on; instead, he took it upon
himself to start compiling things, just so he could compile his shell.
How's that for dedication. -- Wouter, about my Debian/m68k revival


Reply to: