[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#970353: mksh: Ignores "nocheck" in DEB_BUILD_OPTIONS



Finn Thain dixit:

>I think it would be helpful to everyone if nocheck could be avoided where
>possible. I wonder where is that possible.

I’d prefer if it could be added only for problematic packages, or
done in porter uploads, but on the buildds not for all packages.

>Which architectures are using nocheck?

According to the list in, I think, GCC, which I copied, that is on
m68k and sh4. (The package I copied from ignores nocheck on these
architectures as well, as protection from greater issues.)

>Why is it needed for qemu-user on m68k?

It is not needed to build mksh under qemu-user on m68k.

(In fact, mksh’s build process uses the testsuite to determine
whether the klibc-built, musl-built, and/or dietlibc-built
binary of mksh-static works well enough to promote it to /bin/
and uses the same library to compile the lksh binary as well;
if nocheck is given or all three other libraries fail, glibc
(the system libc) is used but it’s… much less suitable, for
static linking especially; this works, e.g. on kfreebsd/hurd,
but glibc is… a moloch.)

>Would it help if test failures could be triaged, such that an "ENOMEM"
>result could be treated as "undecided", since that is what it is?

I highly doubt that. Test failures abort the build, and you
can’t just carry on afterwards.

Plus I think these aren’t even the problems; problematic is
when the testsuite hangs the buildd. (But even so, builds are
killed after some time of inactivity, normally.)

I’d prefer the reason to add nocheck for m68k and sh4 qemu buildds
to be revisited. (Also, do any ARAnyM and bare-metal buildds use
this as well?) Unless needed for qemu-specific reasons, it was a
great tool while helping to get the port back into shape, and I
occasionally need it on porter uploads where the broken functionality
is less important than having the library available as build depen‐
dency, but that is rare and always manual.

bye,
//mirabilos
-- 
<ch> you introduced a merge commit        │<mika> % g rebase -i HEAD^^
<mika> sorry, no idea and rebasing just fscked │<mika> Segmentation
<ch> should have cloned into a clean repo      │  fault (core dumped)
<ch> if I rebase that now, it's really ugh     │<mika:#grml> wuahhhhhh


Reply to: