[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#954091: mypaint: Please honour "nocheck" in DEB_BUILD_OPTIONS

Source: mypaint
Severity: normal
User: debian-68k@lists.debian.org
Usertags: m68k


mypaint overrides the dh_auto_test target in debian/rules without checking
for "nocheck" being set in DEB_BUILD_OPTIONS. This results in the testsuite
being run even though "nocheck" is passed in DEB_BUILD_OPTIONS.

Being able to disable the testsuite is necessary when building packages in
emulated environments where the testsuite might not pass due to emulation
issues or for cross-builds where the testsuite cannot be run due to the
build and target architectures being different.

In order to fix this, the code inside the override_dh_auto_test target should
be guarded with an if conditional which tests for "nocheck" being present

ifeq ($(filter nocheck,$(DEB_BUILD_OPTIONS)),)

See also #908373 [1] for reference.


> [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908373

 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Reply to: